Hook up android webview synchronous compositor GL init

Hook up android webview synchronous compositor GL init

BUG=230197
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205072

[boliu, 2013-06-07 00:40:10]

GL init part 3.

Part 1: https://codereview.chromium.org/14772021/
Part 2: https://codereview.chromium.org/15647021/

[joth, 2013-06-07 01:08:03]

lg2m assuming the other bits all land OK...

https://codereview.chromium.org/16613002/diff/1/content/browser/android/in_pr...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/16613002/diff/1/content/browser/android/in_pr...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:193:
client_->DidLoseOutputSurface();
could base class InitializeAndSetContext3D() handle this too? It does, after
all, handle client_->DeferredInitialize() in the success case.

https://codereview.chromium.org/16613002/diff/1/content/public/browser/androi...
File content/public/browser/android/synchronous_compositor.h (right):

https://codereview.chromium.org/16613002/diff/1/content/public/browser/androi...
content/public/browser/android/synchronous_compositor.h:41: virtual bool
DemandDrawSw(SkCanvas* canvas) = 0;
ubernit : could you instead move this to last so the order is 
initHw
drawHw
drawSw

This will match the in-process view renderer order too then :-)

(+ corresponding change in .cc)

[boliu, 2013-06-07 18:46:17]

Reordered code. Also added back testing-webview-gl-mode switch in
in_process_view_renderer.cc

https://codereview.chromium.org/16613002/diff/1/content/browser/android/in_pr...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/16613002/diff/1/content/browser/android/in_pr...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:193:
client_->DidLoseOutputSurface();
On 2013/06/07 01:08:03, joth wrote:
> could base class InitializeAndSetContext3D() handle this too? It does, after
> all, handle client_->DeferredInitialize() in the success case.

With the new contract in OutputSurface, we can just fall back directly to
software draw mode without recreating this, so removing this call.

[joth, 2013-06-07 18:54:06]

lgtm

[commit-bot: I haz the power, 2013-06-08 00:04:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/16613002/6001

[boliu, 2013-06-08 00:19:17]

+nilesh for content/public/browser/android stamp

[commit-bot: I haz the power, 2013-06-08 00:24:51]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[nilesh, 2013-06-08 00:49:33]

On 2013/06/08 00:19:17, boliu wrote:
> +nilesh for content/public/browser/android stamp

LGTM

[commit-bot: I haz the power, 2013-06-08 00:52:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/16613002/6001

[commit-bot: I haz the power, 2013-06-08 01:22:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-08 01:25:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/16613002/21003

[commit-bot: I haz the power, 2013-06-08 02:01:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-08 02:03:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/16613002/43002

[commit-bot: I haz the power, 2013-06-08 16:46:08]

Change committed as 205072