Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1661103002:
Add blue paper-button. (Closed)
|
Created:
4 years, 10 months ago by chrisphan Modified:
4 years, 10 months ago Reviewers:
qyearsley CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org, sullivan Base URL:
https://github.com/catapult-project/catapult.git@bisect_result_feedback Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionAdd blue paper-button.
Few places can re-use this. Popular for its size.
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a94df6f8610c5101b447c5e69b16644856aaf03d
Patch Set 1 #Patch Set 2 : renamed #Patch Set 3 : update #Patch Set 4 : . #Messages
Total messages: 18 (9 generated)
chrisphan@chromium.org changed reviewers: + qyearsley@chromium.org
This can be re-used anywhere where we have a (blue) "submit"-type button, e.g. in the bisect dialog etc., right? I think if we add this, then there should be a follow-up CL (doing it in this CL is also OK) that changes all of the existing "submit"-type buttons to use it. I think it would be a good idea to make an issue on the issue tracker that this CL and subsequent related CLs can be associated with. Also, what do you think about renaming it as submit-button, primary-button or primary-action-button instead of blue-button, since that would describe the purpose/usage better (and hypothetically if we wanted to change the style so that they were not blue, then we wouldn't have to rename this element)?
On 2016/02/03 23:02:46, qyearsley wrote: > This can be re-used anywhere where we have a (blue) "submit"-type button, e.g. > in the bisect dialog etc., right? > > I think if we add this, then there should be a follow-up CL (doing it in this CL > is also OK) that changes all of the existing "submit"-type buttons to use it. I > think it would be a good idea to make an issue on the issue tracker that this CL > and subsequent related CLs can be associated with. That's correct. May need some additional stuff needed. Currently I made for "bad_bisect.html". > > Also, what do you think about renaming it as submit-button, primary-button or > primary-action-button instead of blue-button, since that would describe the > purpose/usage better (and hypothetically if we wanted to change the style so > that they were not blue, then we wouldn't have to rename this element)? Sure. I think this can be used for any type of action. "primary-button"?
On 2016/02/03 at 23:29:11, chrisphan wrote: > On 2016/02/03 23:02:46, qyearsley wrote: > > This can be re-used anywhere where we have a (blue) "submit"-type button, e.g. > > in the bisect dialog etc., right? > > > > I think if we add this, then there should be a follow-up CL (doing it in this CL > > is also OK) that changes all of the existing "submit"-type buttons to use it. I > > think it would be a good idea to make an issue on the issue tracker that this CL > > and subsequent related CLs can be associated with. > > That's correct. May need some additional stuff needed. Currently I made for "bad_bisect.html". > > > > > Also, what do you think about renaming it as submit-button, primary-button or > > primary-action-button instead of blue-button, since that would describe the > > purpose/usage better (and hypothetically if we wanted to change the style so > > that they were not blue, then we wouldn't have to rename this element)? > > Sure. I think this can be used for any type of action. "primary-button"? LGTM to commit; could you file an issue for the task of changing over the other "submit"-type buttons to use this?
On 2016/02/04 00:06:48, qyearsley wrote: > On 2016/02/03 at 23:29:11, chrisphan wrote: > > On 2016/02/03 23:02:46, qyearsley wrote: > > > This can be re-used anywhere where we have a (blue) "submit"-type button, > e.g. > > > in the bisect dialog etc., right? > > > > > > I think if we add this, then there should be a follow-up CL (doing it in > this CL > > > is also OK) that changes all of the existing "submit"-type buttons to use > it. I > > > think it would be a good idea to make an issue on the issue tracker that > this CL > > > and subsequent related CLs can be associated with. > > > > That's correct. May need some additional stuff needed. Currently I made for > "bad_bisect.html". > > > > > > > > Also, what do you think about renaming it as submit-button, primary-button > or > > > primary-action-button instead of blue-button, since that would describe the > > > purpose/usage better (and hypothetically if we wanted to change the style so > > > that they were not blue, then we wouldn't have to rename this element)? > > > > Sure. I think this can be used for any type of action. "primary-button"? > > LGTM to commit; could you file an issue for the task of changing over the other > "submit"-type buttons to use this? Done
The CQ bit was checked by chrisphan@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1666793002 Patch 1). Please resolve the dependency and try again.
The CQ bit was checked by chrisphan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/1661103002/#ps40001 (title: "update")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1666793002 Patch 1). Please resolve the dependency and try again.
The CQ bit was checked by chrisphan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/1661103002/#ps60001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661103002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661103002/60001
Message was sent while issue was closed.
Description was changed from ========== Add blue paper-button. Few places can re-use this. Popular for its size. ========== to ========== Add blue paper-button. Few places can re-use this. Popular for its size. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
