Ignore ajax on specified pages.

components/autofill/browser/autocheckout_manager.h

Index: components/autofill/browser/autocheckout_manager.h
diff --git a/components/autofill/browser/autocheckout_manager.h b/components/autofill/browser/autocheckout_manager.h
index 4c996f25077cb3a31a620793418040409e3c9f4e..93164fc970a8fa7d7dbf42e60925b756416e0d3f 100644
--- a/components/autofill/browser/autocheckout_manager.h
+++ b/components/autofill/browser/autocheckout_manager.h
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/callback_forward.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string16.h"
@@ -61,6 +62,10 @@ class AutocheckoutManager {
   // Called when a page containing forms is loaded.
   void OnFormsSeen();
 
+  // Whether dynamic form changes on the current page should be ignored during
+  // an Autocheckout flow.
+  bool ShouldIgnoreDynamicFormChanges();
+
   // Causes the Autocheckout bubble to be displayed if the user hasn't seen it
   // yet for the current page. |frame_url| is the page where Autocheckout is
   // being initiated. |ssl_status| is the SSL status of the page. |bounding_box|
@@ -80,6 +85,11 @@ class AutocheckoutManager {
   // Exposed for testing.
   bool autocheckout_offered() const { return autocheckout_offered_; }
 
+  // Exposed for testing.
+  void set_in_autocheckout_flow(bool in_autocheckout_flow) {
+      in_autocheckout_flow_ = in_autocheckout_flow;

[Ilya Sherman, 2013/06/11 01:11:20]

nit: Reduce indentation by two spaces.

[Dane Wallinga, 2013/06/11 19:03:32]

Done.

+  }
+
   // Show the requestAutocomplete dialog if |show_dialog| is true. Also, does
   // bookkeeping for whether or not the bubble is showing.
   virtual void MaybeShowAutocheckoutDialog(const GURL& frame_url,
@@ -152,6 +162,9 @@ class AutocheckoutManager {
 
   base::ThreadChecker thread_checker_;
 
+  friend class AutofillManagerTest;
+  FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DynamicFormsSeenAndIgnored);

[Ilya Sherman, 2013/06/11 01:11:20]

Why are these needed?  Almost always, you should prefer to expose a subset of
the private portion of the class through protected visibility methods +
customized test classes.

[Dane Wallinga, 2013/06/11 19:03:32]

*shrug* - this is the pattern we appear to be using with autofill_manager.

[Ilya Sherman, 2013/06/11 23:14:32]

Alright, let me be clearer: Please do not friend tests other in exceptional
circumstances.  The tradeoff might seem minor in the short-term, but makes a big
difference for long-term maintainability.

[Dane Wallinga, 2013/06/12 20:33:37]

Ok, so AutofillManager has a member AutocheckoutManager autocheckout_manager_.
What I would need then is for TestAutofillManager (defined in
autofill_manager_unittest.cc and extending AutofillManager) to replace this
autocheckout_manager_ with a TestAutocheckoutManager that I would define. What
is the cleanest way I can do that? Keeping in mind that most of what I know
about C++ I've picked up in the last quarter, the simplest thing I can think of
is to turn autocheckout_manager_ into a pointer, and then reassign it in
TestAutofillManager's constructor, but of course that's going to hurt the
performance of AutofillManager just for the sake of a test. Any suggestions?

[Ilya Sherman, 2013/06/15 01:18:19]

Looking more closely at the test code, IMO the best thing would be to not expose
a method set_in_autocheckout_flow() at all, and instead call through the public
API in the normal fashion to trigger an update to this variable.  The reason is
that you're currently not really "mocking out" the boolean's functionality;
you're just editing private state by setting the boolean directly.  The value of
set_foo() methods exposed for testing is in allowing you to mock out
dependencies, rather than to muck with private state.

If for some reason you think that's not appropriate, then yes, the way to
implement this would be to make AutocheckoutManager be a pointer owned by the
AutofillManager class, which test code could override.  The Autofill code is not
so performance-sensitive to where the extra pointer dereference should have a
noticeable performance impact.

+
   DISALLOW_COPY_AND_ASSIGN(AutocheckoutManager);
 };