Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.h

Issue 1661063002: Add message and Help Center link to the chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address estade@'s comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/chooser_bubble_delegate.h
diff --git a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
index 1dd40744a8db323360e1e750e3be79bab6dbb210..93afa8928b7fcac1fbb0ec422e7753763c91de74 100644
--- a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
+++ b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
@@ -12,6 +12,7 @@
#include "components/bubble/bubble_delegate.h"
class Browser;
+class GURL;
// Subclass ChooserBubbleDelegate to implement a chooser bubble, which has
// some introductory text and a list of options that users can pick one of.
@@ -23,6 +24,10 @@ class Browser;
// collecting metrics.
// After Select/Cancel/Close is called, this object is destroyed and call back
// into it is not allowed.
+// TODO(juncai): Change class name ChooserBubbleDelegate to
+// ChooserBubbleController since it better reflects its responsibilities and
+// clarifies the roles of this class.
+// https://crbug.com/588933
class ChooserBubbleDelegate : public BubbleDelegate {
public:
explicit ChooserBubbleDelegate(content::RenderFrameHost* owner);
@@ -52,6 +57,9 @@ class ChooserBubbleDelegate : public BubbleDelegate {
virtual ~Observer() {}
};
+ // Open help center URL.
+ void OpenHelpCenterUrl() const;
+
// BubbleDelegate:
std::string GetName() const override;
scoped_ptr<BubbleUi> BuildBubbleUi() override;
@@ -77,6 +85,9 @@ class ChooserBubbleDelegate : public BubbleDelegate {
// closes without the user taking an explicit action.
virtual void Close() = 0;
+ // Get help center URL.
+ virtual GURL GetHelpCenterUrl() const = 0;
+
// Only one observer may be registered at a time.
void set_observer(Observer* observer) { observer_ = observer; }
Observer* observer() const { return observer_; }

Powered by Google App Engine
This is Rietveld 408576698