Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.cc

Issue 1661063002: Add message and Help Center link to the chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaned up code Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
diff --git a/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc b/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
index 8b209753ca10767380b26589ac56f26ee0fc7d5c..068261900f970be34de52bd2ec9bec79c08bebe0 100644
--- a/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
+++ b/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/net/referrer.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"
#include "content/public/browser/web_contents.h"
@@ -13,6 +14,12 @@ ChooserBubbleDelegate::ChooserBubbleDelegate(content::RenderFrameHost* owner)
ChooserBubbleDelegate::~ChooserBubbleDelegate() {}
+void ChooserBubbleDelegate::OpenHelpCenterURL() const {
+ browser_->OpenURL(content::OpenURLParams(
+ GetHelpCenterURL(), content::Referrer(), NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL, /*is_renderer_initiated=*/true));
Jeffrey Yasskin 2016/02/17 23:54:25 It seems like is_renderer_initiated should be fals
juncai 2016/02/19 01:51:00 Done.
+}
+
std::string ChooserBubbleDelegate::GetName() const {
return "ChooserBubble";
}

Powered by Google App Engine
This is Rietveld 408576698