Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.
Issue 1661063002: Add message and Help Center link to the chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaned up code Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 430376412f23a82413293fec4cdf86317c23f71b..799ca27f183ede8099a876c227a4fa52c157d547 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -14563,6 +14563,14 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
<message name="IDS_CHOOSER_BUBBLE_CANCEL_BUTTON_TEXT" desc="The text that is shown on the cancel button in the chooser popup.">
Cancel
</message>
+ <!-- Chooser Bubble No Device Text -->
+ <message name="IDS_CHOOSER_BUBBLE_NO_DEVICE_TEXT" desc="This text is shown at the bottom of the chooser popup.">
+ Not seeing your device? <ph name="GET_HELP_LINK">$1<ex>Get help</ex></ph>
+ </message>
+ <!-- Chooser Bubble Get Help Link Text -->
+ <message name="IDS_CHOOSER_BUBBLE_GET_HELP_LINK_TEXT" desc="Text of the Get help link at the bottom of the chooser popup.">
msw 2016/02/17 22:58:16 nit: 'Get help'
juncai 2016/02/19 01:51:00 Done.
+ Get help
msw 2016/02/17 22:58:16 Maybe use IDS_GET_HELP?
juncai 2016/02/19 01:51:00 There is already an IDS_GET_HELP: https://code.goo
Jeffrey Yasskin 2016/02/19 21:25:40 I think msw is suggesting that you use that existi
juncai 2016/02/20 02:25:04 I tried using IDS_GET_HELP, it didn't work. Also i
Jeffrey Yasskin 2016/02/22 19:54:15 "It didn't work" doesn't help the reviewers figure
msw 2016/02/22 20:13:11 I don't think there's a common pattern for removin
juncai 2016/02/22 22:06:37 Thanks. The '&' was visible in the UI when I tried
+ </message>
</if>
<if expr="is_android">

Powered by Google App Engine
This is Rietveld 408576698