Add message and Help Center link to the chooser UI

chrome/browser/ui/website_settings/chooser_bubble_delegate.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/browser/net/referrer.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/host_desktop.h"
+#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"
 #include "content/public/browser/web_contents.h"
 
+namespace {
+
+Browser* GetBrowser() {
+  chrome::ScopedTabbedBrowserDisplayer browser_displayer(
+      ProfileManager::GetActiveUserProfile());
+  DCHECK(browser_displayer.browser());
+  return browser_displayer.browser();
+}
+
+void OpenURL(const GURL& url) {
+  GetBrowser()->OpenURL(

[Jeffrey Yasskin, 2016/02/17 01:33:45]

It seems wrong to conjure a browser window out of nothing. Shouldn't it be the
same window as the bubble's showing in?

[palmer, 2016/02/17 02:19:53]

FWIW: The What Do These Mean? link in the (soon to go away) Connection Tab in
the Origin Info Bubble opens a new (foreground) tab. I don't know if that's the
best thing, but it seems bad to destroy/lose any context in the current
tab/window.

[juncai, 2016/02/17 22:40:40]

Since ChooserBubbleDelegate has a Browser* member variable, I use it to open the
URL instead.

[Jeffrey Yasskin, 2016/02/17 23:54:25]

Awesome, thanks.

+      content::OpenURLParams(url, content::Referrer(), NEW_BACKGROUND_TAB,

[Jeffrey Yasskin, 2016/02/17 01:33:45]

I think we want this to be a FOREGROUND_TAB, to make sure the user sees it. 
(OMG, who decided that enum didn't need comments??)

[juncai, 2016/02/17 22:40:40]

Done.

+                             ui::PAGE_TRANSITION_AUTO_TOPLEVEL, true));

[Jeffrey Yasskin, 2016/02/17 01:33:45]

Always comment naked boolean arguments like this. I usually use
/*arg_name=*/true, but I don't care much as long as we can tell what "true"
means.

[juncai, 2016/02/17 22:40:40]

Done.

+}
+
+}  // namespace
+
 ChooserBubbleDelegate::ChooserBubbleDelegate(content::RenderFrameHost* owner)
     : browser_(chrome::FindBrowserWithWebContents(
           content::WebContents::FromRenderFrameHost(owner))),
       owning_frame_(owner) {}
 
 ChooserBubbleDelegate::~ChooserBubbleDelegate() {}
 
+void ChooserBubbleDelegate::OpenHelpCenterURL() const {
+  OpenURL(GetHelpCenterURL());
+}
+
 std::string ChooserBubbleDelegate::GetName() const {
   return "ChooserBubble";
 }
 
 const content::RenderFrameHost* ChooserBubbleDelegate::OwningFrame() const {
   return owning_frame_;
 }