Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1661043003: Remove old recipe modules. (Closed)

Created:
4 years, 10 months ago by martiniss
Modified:
4 years, 10 months ago
Reviewers:
estaab, M-A Ruel, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove old recipe modules. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298654

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
D infra/recipe_modules/depot_tools/api.py View 1 chunk +0 lines, -12 lines 0 comments Download
D infra/recipe_modules/depot_tools/example.py View 1 chunk +0 lines, -14 lines 0 comments Download
D infra/recipe_modules/depot_tools/example.expected/basic.json View 1 chunk +0 lines, -17 lines 0 comments Download

Depends on Patchset:

Issue 1669613002 Patch 1

Messages

Total messages: 14 (5 generated)
martiniss
PTAL
4 years, 10 months ago (2016-02-03 21:38:45 UTC) #2
estaab
On 2016/02/03 21:38:45, martiniss wrote: > PTAL Besides codesearch is there a good way to ...
4 years, 10 months ago (2016-02-03 21:53:33 UTC) #3
martiniss
On 2016/02/03 at 21:53:33, estaab wrote: > On 2016/02/03 21:38:45, martiniss wrote: > > PTAL ...
4 years, 10 months ago (2016-02-08 21:13:14 UTC) #4
estaab
lgtm
4 years, 10 months ago (2016-02-08 21:17:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661043003/20001
4 years, 10 months ago (2016-02-08 21:22:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/442)
4 years, 10 months ago (2016-02-08 21:27:06 UTC) #9
iannucci
(lgtm)
4 years, 10 months ago (2016-02-09 01:40:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661043003/20001
4 years, 10 months ago (2016-02-09 01:40:25 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 01:42:20 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298654

Powered by Google App Engine
This is Rietveld 408576698