Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1661013002: Atomic scaling in ImageResource::imageSize() (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 10 months ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Atomic scaling in ImageResource::imageSize() Since https://codereview.chromium.org/1634133003/ there is only hasRelativeSize(), no hasRelative{Width,Height}(). The code affected by this patch was written under the latter assumption. With only hasRelativeSize() the code can be simplified a bit to either scale or return early. Also remove useless ASSERT. |multiplier| is always non-equal to one in that code branch so the assert doesn't check anything meaningful. BUG=581357 Committed: https://crrev.com/c09e2ebef160275d02ebdfbe3615378c81f04523 Cr-Commit-Position: refs/heads/master@{#373496}

Patch Set 1 #

Patch Set 2 : Use integer literals for floats when possible; remove useless assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661013002/1
4 years, 10 months ago (2016-02-03 17:00:45 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 18:37:48 UTC) #4
davve
Follow-up to https://codereview.chromium.org/1634133003/
4 years, 10 months ago (2016-02-04 08:53:35 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661013002/20001
4 years, 10 months ago (2016-02-04 08:54:08 UTC) #9
fs
lgtm
4 years, 10 months ago (2016-02-04 09:11:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661013002/20001
4 years, 10 months ago (2016-02-04 09:15:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 10:26:49 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 10:28:06 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c09e2ebef160275d02ebdfbe3615378c81f04523
Cr-Commit-Position: refs/heads/master@{#373496}

Powered by Google App Engine
This is Rietveld 408576698