Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: webkit/glue/plugins/test/plugin_test.cc

Issue 1661: port some parts of webkit/glue/plugins/test to Linux... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/plugins/test/plugin_test.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/test/plugin_test.cc
===================================================================
--- webkit/glue/plugins/test/plugin_test.cc (revision 2299)
+++ webkit/glue/plugins/test/plugin_test.cc (working copy)
@@ -3,6 +3,8 @@
// found in the LICENSE file.
#include "webkit/glue/plugins/test/plugin_test.h"
+
+#include "base/string_util.h"
#include "webkit/glue/plugins/test/npapi_constants.h"
namespace NPAPIClient {
@@ -32,8 +34,8 @@
// end up using libicu, which is a string of dependencies we don't
// want.
-inline BYTE toHex(const BYTE &x) {
- return x > 9 ? x + 55: x + 48;
+inline unsigned char toHex(const unsigned char x) {
+ return x > 9 ? (x + 'A' - 10) : (x + '0');
}
std::string URLEncode(const std::string &sIn) {
@@ -88,7 +90,7 @@
const char *PluginTest::GetArgValue(const char *name, const int16 argc,
const char *argn[], const char *argv[]) {
for (int idx = 0; idx < argc; idx++)
- if (_stricmp(argn[idx], name) == 0)
+ if (base::strcasecmp(argn[idx], name) == 0)
return argv[idx];
return NULL;
}
« no previous file with comments | « webkit/glue/plugins/test/plugin_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698