Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: pkg/docgen/lib/docgen.dart

Issue 166093006: pkg/docgen: removed py files, doc/README.txt, fixed analyzer warning (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: a bit more strict Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/docgen/doc/README.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/docgen/lib/docgen.dart
diff --git a/pkg/docgen/lib/docgen.dart b/pkg/docgen/lib/docgen.dart
index 50dd6f28e62aa9ec67606b87fa65409f2e8894d6..4c84f72cadb33ccb96e99e1d8cf6405aa7b8a8c9 100644
--- a/pkg/docgen/lib/docgen.dart
+++ b/pkg/docgen/lib/docgen.dart
@@ -117,7 +117,7 @@ Future<bool> docgen(List<String> files, {String packageRoot,
bool parseSdk: false, bool append: false, String introFileName: '',
out: _DEFAULT_OUTPUT_DIRECTORY, List<String> excludeLibraries : const [],
bool includeDependentPackages: false, bool compile: false, bool serve: false,
- bool noDocs: false, String startPage,
+ bool noDocs: false, String startPage,
String pubScript, String dartBinary}) {
var result;
if (!noDocs) {
@@ -136,7 +136,7 @@ Future<bool> docgen(List<String> files, {String packageRoot,
_createViewer(serve);
}
});
- }
+ }
} else if (compile || serve) {
_createViewer(serve);
}
@@ -149,7 +149,7 @@ void _createViewer(bool serve) {
if (serve) {
_Viewer._runServer();
}
-}
+}
/// Analyzes set of libraries by getting a mirror system and triggers the
/// documentation of the libraries.
@@ -696,7 +696,7 @@ class _Viewer {
/// Move the generated json/yaml docs directory to the dartdoc-viewer
/// directory, to run as a webpage.
var processResult = Process.runSync(_Generator._pubScript,
- ['upgrade'], runInShell: true,
+ ['upgrade'], runInShell: true,
workingDirectory: path.join(_dartdocViewerDir.path, 'client'));
print('process output: ${processResult.stdout}');
print('process stderr: ${processResult.stderr}');
@@ -1589,6 +1589,8 @@ abstract class OwnedIndexable extends Indexable {
var parts = domName.split('.');
if (parts.length == 2) return _mdnMemberComment(parts[0], parts[1]);
if (parts.length == 1) return _mdnTypeComment(parts[0]);
+
+ throw new StateError('More than two items is not supported: $parts');
kevmoo 2014/02/17 20:27:21 Going with being strict. If the code isn't designe
}
String get packagePrefix => owner.packagePrefix;
« no previous file with comments | « pkg/docgen/doc/README.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698