Chromium Code Reviews| Index: pkg/docgen/lib/docgen.dart |
| diff --git a/pkg/docgen/lib/docgen.dart b/pkg/docgen/lib/docgen.dart |
| index 50dd6f28e62aa9ec67606b87fa65409f2e8894d6..8ed0c3e8b8bfa3bc97dc1d77b787379259164573 100644 |
| --- a/pkg/docgen/lib/docgen.dart |
| +++ b/pkg/docgen/lib/docgen.dart |
| @@ -117,7 +117,7 @@ Future<bool> docgen(List<String> files, {String packageRoot, |
| bool parseSdk: false, bool append: false, String introFileName: '', |
| out: _DEFAULT_OUTPUT_DIRECTORY, List<String> excludeLibraries : const [], |
| bool includeDependentPackages: false, bool compile: false, bool serve: false, |
| - bool noDocs: false, String startPage, |
| + bool noDocs: false, String startPage, |
| String pubScript, String dartBinary}) { |
| var result; |
| if (!noDocs) { |
| @@ -136,7 +136,7 @@ Future<bool> docgen(List<String> files, {String packageRoot, |
| _createViewer(serve); |
| } |
| }); |
| - } |
| + } |
| } else if (compile || serve) { |
| _createViewer(serve); |
| } |
| @@ -149,7 +149,7 @@ void _createViewer(bool serve) { |
| if (serve) { |
| _Viewer._runServer(); |
| } |
| -} |
| +} |
| /// Analyzes set of libraries by getting a mirror system and triggers the |
| /// documentation of the libraries. |
| @@ -696,7 +696,7 @@ class _Viewer { |
| /// Move the generated json/yaml docs directory to the dartdoc-viewer |
| /// directory, to run as a webpage. |
| var processResult = Process.runSync(_Generator._pubScript, |
| - ['upgrade'], runInShell: true, |
| + ['upgrade'], runInShell: true, |
| workingDirectory: path.join(_dartdocViewerDir.path, 'client')); |
| print('process output: ${processResult.stdout}'); |
| print('process stderr: ${processResult.stderr}'); |
| @@ -1589,6 +1589,9 @@ abstract class OwnedIndexable extends Indexable { |
| var parts = domName.split('.'); |
| if (parts.length == 2) return _mdnMemberComment(parts[0], parts[1]); |
| if (parts.length == 1) return _mdnTypeComment(parts[0]); |
| + |
| + //TODO(efortuna): an valid cases where parts.length is not 1 or 2? |
|
Emily Fortuna
2014/02/14 22:26:41
1) an -> any?
2) it's considered bad form in the
|
| + return null; |
| } |
| String get packagePrefix => owner.packagePrefix; |