Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 166093005: Clear m_lastImageId for software compositor (Closed)

Created:
6 years, 10 months ago by boliu
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clear m_lastImageId for software compositor When android webview swith to software only mode, all mailboxes are returned to Canvas2DLayerBridge. In this case, if the canvas is static, then prepareMailbox will never return a new mailbox. So clear m_lastImageId in this case. BUG=239864 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167365

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download
M Source/web/tests/Canvas2DLayerBridgeTest.cpp View 1 4 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
boliu
A much simpler solution to the android webview static canvas issue. PTAL!
6 years, 10 months ago (2014-02-14 21:35:26 UTC) #1
boliu
junov: ping?
6 years, 10 months ago (2014-02-18 15:14:35 UTC) #2
Justin Novosad
On 2014/02/18 15:14:35, boliu wrote: > junov: ping? Is there a test for this? Are ...
6 years, 10 months ago (2014-02-18 16:47:22 UTC) #3
boliu
On 2014/02/18 16:47:22, junov wrote: > On 2014/02/18 15:14:35, boliu wrote: > > junov: ping? ...
6 years, 10 months ago (2014-02-18 16:51:21 UTC) #4
boliu
Added a tiny unit test. PTAL
6 years, 10 months ago (2014-02-18 17:15:01 UTC) #5
Justin Novosad
On 2014/02/18 17:15:01, boliu wrote: > Added a tiny unit test. PTAL lgtm Since the ...
6 years, 10 months ago (2014-02-18 17:51:46 UTC) #6
boliu
+aelias for Source/web stamp
6 years, 10 months ago (2014-02-18 17:56:24 UTC) #7
aelias_OOO_until_Jul13
Source/web/tests/ lgtm
6 years, 10 months ago (2014-02-18 19:19:49 UTC) #8
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 10 months ago (2014-02-18 19:22:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/166093005/90001
6 years, 10 months ago (2014-02-18 19:22:35 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 22:07:38 UTC) #11
Message was sent while issue was closed.
Change committed as 167365

Powered by Google App Engine
This is Rietveld 408576698