Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 166093004: Avoid some code duplication in HTMLTableRowsCollection::rowAfter() (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
cmp, adamk, eseidel
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid some code duplication in HTMLTableRowsCollection::rowAfter() Avoid some code duplication in HTMLTableRowsCollection::rowAfter() by factoring out the code for finding a table row element among children to a new function. This code was repeated 3 times. R=adamk, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M Source/core/html/HTMLTableRowsCollection.cpp View 4 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
Sorry, I should have done this when I updated this function yesterday but I thought ...
6 years, 10 months ago (2014-02-14 18:58:25 UTC) #1
eseidel
lgtm
6 years, 10 months ago (2014-02-14 19:18:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/166093004/1
6 years, 10 months ago (2014-02-14 19:19:21 UTC) #3
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 10 months ago (2014-02-15 18:37:29 UTC) #4
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 10 months ago (2014-02-15 18:37:31 UTC) #5
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 10 months ago (2014-02-15 18:37:33 UTC) #6
cmp
On 2014/02/15 18:37:33, cmp wrote: > The CQ bit was unchecked by mailto:cmp@chromium.org Noted the ...
6 years, 10 months ago (2014-02-15 18:38:41 UTC) #7
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 10 months ago (2014-02-15 18:43:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/166093004/1
6 years, 10 months ago (2014-02-15 18:43:45 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 19:31:48 UTC) #10
Message was sent while issue was closed.
Change committed as 167242

Powered by Google App Engine
This is Rietveld 408576698