Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1660903002: [runtime] Remove receiver==holder check in IntegerIndexedExotic lookup (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove receiver==holder check in IntegerIndexedExotic lookup This was inconsistent in the spec in case of has vs get, set. Removing receiver==holder simplifies the lookup; so tentatively removing this additional check which was broken until yesterday anyway. See https://github.com/tc39/ecma262/issues/347 for more information. Committed: https://crrev.com/158cd5cb5e2c5e8312fc41b5a25129d7c2439120 Cr-Commit-Position: refs/heads/master@{#33701}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 1 4 chunks +14 lines, -20 lines 0 comments Download
M test/mjsunit/regress/regress-integer-indexed-element.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-03 09:41:51 UTC) #2
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-03 09:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660903002/20001
4 years, 10 months ago (2016-02-03 10:04:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 10:30:09 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 10:30:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/158cd5cb5e2c5e8312fc41b5a25129d7c2439120
Cr-Commit-Position: refs/heads/master@{#33701}

Powered by Google App Engine
This is Rietveld 408576698