Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1660873003: Clone and link all tokens in AstCloner. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -912 lines) Patch
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 7 chunks +94 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 4 chunks +12 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 3 chunks +377 lines, -897 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-03 22:28:09 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-03 23:08:46 UTC) #2
scheglov
4 years, 10 months ago (2016-02-04 05:31:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0232570f44710961bf7876460026e76a19ef611b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698