Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1660863003: Add timestamp=none to codesign flags. (Closed)

Created:
4 years, 10 months ago by justincohen
Modified:
4 years, 10 months ago
Reviewers:
Nico, sdefresne
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Add timestamp=none to codesign flags. Keep gyp codesign flags in line with Xcode. BUG=577711 R=sdefresne@chromium.org, thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/32cb1709adc33d8cfd220ab1437ff84139690b6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pylib/gyp/mac_tool.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
justincohen
4 years, 10 months ago (2016-02-03 16:35:31 UTC) #2
sdefresne
It's strange that Xcode by default uses "none" there (though it kind of make sense ...
4 years, 10 months ago (2016-02-03 16:46:12 UTC) #3
justincohen
ptal
4 years, 10 months ago (2016-02-05 17:24:48 UTC) #5
Nico
rs-lgtm
4 years, 10 months ago (2016-02-05 17:59:45 UTC) #6
justincohen
4 years, 10 months ago (2016-02-05 21:15:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32cb1709adc33d8cfd220ab1437ff84139690b6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698