third_party/WebKit/Source/platform/geometry/LayoutPoint.h - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutPoint.h

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix multicol Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/geometry/LayoutPoint.h

diff --git a/third_party/WebKit/Source/platform/geometry/LayoutPoint.h b/third_party/WebKit/Source/platform/geometry/LayoutPoint.h

index b61956b3e0c902dbb383f3f465e363cb72f0b1bf..fad220f0d7a33d26a4ad745c361db9fe49ff7626 100644

--- a/third_party/WebKit/Source/platform/geometry/LayoutPoint.h

+++ b/third_party/WebKit/Source/platform/geometry/LayoutPoint.h

@@ -45,6 +45,7 @@ class LayoutPoint {

public:

LayoutPoint() { }

LayoutPoint(LayoutUnit x, LayoutUnit y) : m_x(x), m_y(y) { }

+ LayoutPoint(int x, int y) : m_x(LayoutUnit(x)), m_y(LayoutUnit(y)) { }

eae 2016/02/12 01:14:59 This has many of the same problems, I assume it is

LayoutPoint(const IntPoint& point) : m_x(point.x()), m_y(point.y()) { }

explicit LayoutPoint(const FloatPoint& point) : m_x(point.x()), m_y(point.y()) { }

explicit LayoutPoint(const DoublePoint& point) : m_x(point.x()), m_y(point.y()) { }