third_party/WebKit/Source/core/layout/line/LineWidth.cpp - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

index ce039c944ea3d090f84cd15c4e2b345d5a671c92..c69d9e493406a3d82dfb41b85c40ebaf4d94feef 100644

--- a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

+++ b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

@@ -157,7 +157,7 @@ void LineWidth::wrapNextToShapeOutside(bool isFirstLine)

newLineTop++;

}

- updateLineDimension(newLineTop, newLineWidth, newLineLeft, newLineRight);

+ updateLineDimension(newLineTop, LayoutUnit(newLineWidth), newLineLeft, newLineRight);

}

void LineWidth::fitBelowFloats(bool isFirstLine)

@@ -187,7 +187,7 @@ void LineWidth::fitBelowFloats(bool isFirstLine)

if (newLineWidth >= m_uncommittedWidth)

break;

}

- updateLineDimension(lastFloatLogicalBottom, newLineWidth, newLineLeft, newLineRight);

+ updateLineDimension(lastFloatLogicalBottom, LayoutUnit(newLineWidth), newLineLeft, newLineRight);

}

void LineWidth::computeAvailableWidthFromLeftAndRight()