DescriptionReland of Do Perfect Forwarding from base::Bind to BindState storage (patchset #1 id:1 of https://codereview.chromium.org/1654973003/ )
Reason for revert:
An size_t to uint32_t implicit conversion causes a compile error, which was fixed separately as http://crrev.com/f246b3224a5371fb
Original issue's description:
> Revert of Do Perfect Forwarding from base::Bind to BindState storage (patchset #2 id:20001 of https://codereview.chromium.org/1644603003/ )
>
> Reason for revert:
> This CL broke Windows build at an instantiation for:
> e:\b\build\slave\win_x64_gn__dbg_\build\src\components\mus\gles2\command_buffer_local.cc(195)
>
> The error message is:
> e:\b\build\slave\win_x64_gn__dbg_\build\src\base\bind_internal.h(291) : warning C4267: 'argument' : conversion from 'size_t' to 'const uint32_t', possible loss of data
>
> https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/17854/steps/compile/logs/stdio
>
> Original issue's description:
> > Do Perfect Forwarding from base::Bind to BindState storage
> >
> > Replace StorageType usage with std::decay and do Perfect Forwarding from
> > base::Bind to BindState storage as a preparation to store a move-only
> > type into BindState.
> >
> > The difference of StorageType and std::decay is essentially array
> > handling. CallbackParamTraits::StorageType converts "T[n]" to "const T*"
> > OTOH std::decay converts it to "T*".
> >
> > BUG=554299
> >
> > Committed: https://crrev.com/cdec75e36dd5ec9c5643f7b473e166a3acef81ea
> > Cr-Commit-Position: refs/heads/master@{#372900}
>
> TBR=danakj@chromium.org,thakis@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=554299
>
> Committed: https://crrev.com/582cbf4e94a9a53f73ba5125de0d70afadc300ad
> Cr-Commit-Position: refs/heads/master@{#372903}
TBR=danakj@chromium.org,thakis@chromium.org
BUG=554299
Committed: https://crrev.com/0e9150fda9ea8d072b74c2580e47279c1073a650
Cr-Commit-Position: refs/heads/master@{#373172}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|