Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1660833002: Reland of Do Perfect Forwarding from base::Bind to BindState storage (Closed)

Created:
4 years, 10 months ago by tzik
Modified:
4 years, 10 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org, Nico, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Do Perfect Forwarding from base::Bind to BindState storage (patchset #1 id:1 of https://codereview.chromium.org/1654973003/ ) Reason for revert: An size_t to uint32_t implicit conversion causes a compile error, which was fixed separately as http://crrev.com/f246b3224a5371fb Original issue's description: > Revert of Do Perfect Forwarding from base::Bind to BindState storage (patchset #2 id:20001 of https://codereview.chromium.org/1644603003/ ) > > Reason for revert: > This CL broke Windows build at an instantiation for: > e:\b\build\slave\win_x64_gn__dbg_\build\src\components\mus\gles2\command_buffer_local.cc(195) > > The error message is: > e:\b\build\slave\win_x64_gn__dbg_\build\src\base\bind_internal.h(291) : warning C4267: 'argument' : conversion from 'size_t' to 'const uint32_t', possible loss of data > > https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/17854/steps/compile/logs/stdio > > Original issue's description: > > Do Perfect Forwarding from base::Bind to BindState storage > > > > Replace StorageType usage with std::decay and do Perfect Forwarding from > > base::Bind to BindState storage as a preparation to store a move-only > > type into BindState. > > > > The difference of StorageType and std::decay is essentially array > > handling. CallbackParamTraits::StorageType converts "T[n]" to "const T*" > > OTOH std::decay converts it to "T*". > > > > BUG=554299 > > > > Committed: https://crrev.com/cdec75e36dd5ec9c5643f7b473e166a3acef81ea > > Cr-Commit-Position: refs/heads/master@{#372900} > > TBR=danakj@chromium.org,thakis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=554299 > > Committed: https://crrev.com/582cbf4e94a9a53f73ba5125de0d70afadc300ad > Cr-Commit-Position: refs/heads/master@{#372903} TBR=danakj@chromium.org,thakis@chromium.org BUG=554299 Committed: https://crrev.com/0e9150fda9ea8d072b74c2580e47279c1073a650 Cr-Commit-Position: refs/heads/master@{#373172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -35 lines) Patch
M base/bind.h View 3 chunks +5 lines, -7 lines 0 comments Download
M base/bind_internal.h View 2 chunks +5 lines, -3 lines 0 comments Download
M base/callback_internal.h View 4 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tzik
Created Reland of Do Perfect Forwarding from base::Bind to BindState storage
4 years, 10 months ago (2016-02-03 02:59:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660833002/1
4 years, 10 months ago (2016-02-03 03:03:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 04:42:37 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 04:43:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e9150fda9ea8d072b74c2580e47279c1073a650
Cr-Commit-Position: refs/heads/master@{#373172}

Powered by Google App Engine
This is Rietveld 408576698