Make m_IndexArray sane.

Make m_IndexArray sane.

This was an obstacle to removing CFX_DWordArray; rather than
rote conversion of an array where the even elements mean one
thing and the odd elements another, make an array of pairs.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/7c87508ae4b8300caf97aebffae42ba2c7fd6e52

[Tom Sepez, 2016-02-02 23:21:46]

Description was changed from

==========
Make m_IndexArray sane.
==========

to

==========
Make m_IndexArray sane.

This was an obstacle to removing CFX_DWordArray; rather than
rote conversion of an array where the even elements mean one thing and the odd
elements another, make an array of pairs.
==========

[Tom Sepez, 2016-02-02 23:21:46]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-02 23:21:58]

for review.

[Tom Sepez, 2016-02-02 23:22:15]

Description was changed from

==========
Make m_IndexArray sane.

This was an obstacle to removing CFX_DWordArray; rather than
rote conversion of an array where the even elements mean one thing and the odd
elements another, make an array of pairs.
==========

to

==========
Make m_IndexArray sane.

This was an obstacle to removing CFX_DWordArray; rather than
rote conversion of an array where the even elements mean one
thing and the odd elements another, make an array of pairs.
==========

[Lei Zhang, 2016-02-03 00:03:28]

lgtm

https://codereview.chromium.org/1660733002/diff/20001/core/src/fpdfapi/fpdf_e...
File core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1660733002/diff/20001/core/src/fpdfapi/fpdf_e...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:344: int32_t iCount = 0;
FX_DWORD

https://codereview.chromium.org/1660733002/diff/20001/core/src/fpdfapi/fpdf_e...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:673: int32_t iSeg =
m_IndexArray.size();
Is it easy to change this and |m_iSeg| to size_t?

https://codereview.chromium.org/1660733002/diff/20001/core/src/fpdfapi/fpdf_e...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:893: FX_DWORD nextobjnum =
m_IndexArray.back().objnum + m_IndexArray.back().count;
nit: next_objnum

[Tom Sepez, 2016-02-03 00:12:16]

https://codereview.chromium.org/1660733002/diff/20001/core/src/fpdfapi/fpdf_e...
File core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1660733002/diff/20001/core/src/fpdfapi/fpdf_e...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:344: int32_t iCount = 0;
On 2016/02/03 00:03:28, Lei Zhang wrote:
> FX_DWORD

Done.

https://codereview.chromium.org/1660733002/diff/20001/core/src/fpdfapi/fpdf_e...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:673: int32_t iSeg =
m_IndexArray.size();
On 2016/02/03 00:03:28, Lei Zhang wrote:
> Is it easy to change this and |m_iSeg| to size_t?

Let's try.

[Tom Sepez, 2016-02-03 20:27:46]

Description was changed from

==========
Make m_IndexArray sane.

This was an obstacle to removing CFX_DWordArray; rather than
rote conversion of an array where the even elements mean one
thing and the odd elements another, make an array of pairs.
==========

to

==========
Make m_IndexArray sane.

This was an obstacle to removing CFX_DWordArray; rather than
rote conversion of an array where the even elements mean one
thing and the odd elements another, make an array of pairs.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/7c87508ae4b8300caf97aebffae42ba2c7fd...
==========

[Tom Sepez, 2016-02-03 20:27:47]

Committed patchset #3 (id:40001) manually as
7c87508ae4b8300caf97aebffae42ba2c7fd6e52 (presubmit successful).