Issue 166073007: Fixed clean URLs for GCS file system provider in the documentation server.

Issue 166073007: Fixed clean URLs for GCS file system provider in the documentation server. (Closed)

Created:
6 years, 10 months ago by Renato Mangini (chromium)

Modified:
6 years, 8 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixed clean URLs for GCS file system provider in the documentation server. NOTRY=true R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251528

Patch Set 2 : addressed comments; added keyboard style to keys in documentation (not related to this CL) #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -12 lines)			Patch
	M	chrome/common/extensions/docs/server2/gcs_file_system.py	View	1	3 chunks	+10 lines, -12 lines	0 comments	Download
	M	chrome/common/extensions/docs/static/sass/_typography.scss	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm but I made another comment in the other place that listfiles is used https://codereview.chromium.org/166073007/diff/1/chrome/common/extensions/docs/server2/gcs_file_system.py ...

6 years, 10 months ago (2014-02-14 23:03:55 UTC) #2

Renato Mangini (chromium)

addressed comments. https://codereview.chromium.org/166073007/diff/1/chrome/common/extensions/docs/server2/gcs_file_system.py File chrome/common/extensions/docs/server2/gcs_file_system.py (right): https://codereview.chromium.org/166073007/diff/1/chrome/common/extensions/docs/server2/gcs_file_system.py#newcode59 chrome/common/extensions/docs/server2/gcs_file_system.py:59: for _file in cloudstorage_api.listbucket('/' + full_path): On ...

6 years, 10 months ago (2014-02-15 02:01:52 UTC) #3

Renato Mangini (chromium)

The CQ bit was checked by mangini@chromium.org

6 years, 10 months ago (2014-02-15 02:01:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/166073007/60001

6 years, 10 months ago (2014-02-15 02:02:36 UTC) #5

Message was sent while issue was closed.

Change committed as 251528

Expand Messages | Collapse Messages