third_party/android_platform/README.chromium - Issue 1660693002: Add --output-dir flag to third_party/android_platform/development/scripts/stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_platform/README.chromium

Issue 1660693002: Add --output-dir flag to third_party/android_platform/development/scripts/stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix fix fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/android_platform/README.chromium

diff --git a/third_party/android_platform/README.chromium b/third_party/android_platform/README.chromium

index d0064a412837296db7280edcae15afc6d720aeca..cc0a66679cb9d8b193abd4c879f3de90508c0d59 100644

--- a/third_party/android_platform/README.chromium

+++ b/third_party/android_platform/README.chromium

@@ -25,7 +25,7 @@ The scripts have been modified to better suit Chromium development. Changes

include, but are not limited to, the following:

Added memoization of addr2line and objdump.

Added option to change the amount of symbolization done.

-Updated output directories to use environment variable.

+Updated output directories to be set by environment variable or --flags

When calling addr2line, check the symbol is a file that looks like it contains

symbols.

Added support for parsing LOG(FATAL) and DCHECK errors and their

« no previous file with comments | « build/android/tombstones.py ('k') | third_party/android_platform/development/scripts/stack » ('j') | no next file with comments »