Resynthesize generic class instance creations.

Resynthesize generic class instance creations.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/678048132b66783a40bb39d96fa3b649ddb7fe76

[Paul Berry, 2016-02-02 22:01:16]

lgtm

https://codereview.chromium.org/1660663002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1660663002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:512: constructorElement =
_createConstructorElement(ref, info);
Nit: since the logic is the same for both constructor elements and class
elements, this line and line 515 can be lifted out of the conditional and merged
with line 509.

[scheglov, 2016-02-02 22:27:32]

Description was changed from

==========
Resynthesize generic class instance creations.

R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize generic class instance creations.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/678048132b66783a40bb39d96fa3b649ddb7fe76
==========

[scheglov, 2016-02-02 22:27:36]

Committed patchset #1 (id:1) manually as
678048132b66783a40bb39d96fa3b649ddb7fe76 (presubmit successful).

[scheglov, 2016-02-02 22:28:04]

https://codereview.chromium.org/1660663002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1660663002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:512: constructorElement =
_createConstructorElement(ref, info);
On 2016/02/02 22:01:16, Paul Berry wrote:
> Nit: since the logic is the same for both constructor elements and class
> elements, this line and line 515 can be lifted out of the conditional and
merged
> with line 509.

Ah, yes.
This code used to be much more complex and different.
But now it is the same.
Thanks!