Check configuration for L2TP/IPsec+certificate VPN network with UIData.

Check configuration for L2TP/IPsec+certificate VPN network with UIData.

In the LT2P/IPsec + user certificate VPN flow, if the UIData does not
contain any certificate properties, it is possible that the certificate
properties are still configured by shill (e.g. the properties were
previously configured and saved in the shill profile). However,
client_cert::IsCertificateConfigured() did not take that into account,
which caused NetworkConnectionHandler::VerifyConfiguredAndConnect() to
always throw a 'configuration required' error and the VPN configuration
dialog to pop up even when all the credentials information was
available. Also, VPNRequiresCredentials didn't check the from the
Provider.PassphraseRequired property to see if shill expects a user
passphrase for the VPN connection. This CL fixes these issues.

BUG=307665
TEST=Verified the following scenarios:
1. Add a 'L2TP/IPsec + user certificate' VPN with 'Save identity and
   password' unchecked. Connect to the VPN once and then reboot the system.
   Reconnect to the VPN and verify that it prompts for credentials.
2. Repeat 1 but with 'Save identity and password' checked and verify
   that it reconnects without prompting for credentials.

R=pneubeck@chromium.org, stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251410

[stevenjb, 2014-02-14 16:44:12]

This lgtm, but pneubeck@ should take a look too.

https://codereview.chromium.org/166063003/diff/1/chromeos/network/client_cert...
File chromeos/network/client_cert_util.cc (right):

https://codereview.chromium.org/166063003/diff/1/chromeos/network/client_cert...
chromeos/network/client_cert_util.cc:262: case CONFIG_TYPE_IPSEC: {
nit: if (!provider_properties) return false;

[pneubeck (no reviews), 2014-02-14 16:58:44]

lgtm. and this shows again, that we need unit tests for this.
please try to add some.

[stevenjb, 2014-02-14 19:06:17]

Additional change lgtm

[Ben Chan, 2014-02-14 20:24:53]

Committed patchset #3 manually as r251410 (presubmit successful).