Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1660613005: [Interpreter] Skips a failing test on arm64. (Closed)

Created:
4 years, 10 months ago by mythria
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Skips a failing test on arm64. Skips cctest/test-heap/NoWeakHashTableLeakWithIncrementalMarking that is crashing on arm64. BUG=v8:4280 LOG=N NOTRY=true Committed: https://crrev.com/ee4efed7404d9b54d26dff50ceae97d2fa0adec2 Cr-Commit-Position: refs/heads/master@{#33708}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addresses comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mythria
Thanks for pointing this Michael. Fixed it. PTAL, Thanks, Mythri
4 years, 10 months ago (2016-02-03 15:22:23 UTC) #2
rmcilroy
LGTM. Please also add "NOTRY=true" to the CL description so that it bypasses the CQ ...
4 years, 10 months ago (2016-02-03 15:26:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660613005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660613005/20001
4 years, 10 months ago (2016-02-03 15:29:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 15:31:15 UTC) #9
Michael Achenbach
lgtm
4 years, 10 months ago (2016-02-03 15:31:30 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 15:31:39 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee4efed7404d9b54d26dff50ceae97d2fa0adec2
Cr-Commit-Position: refs/heads/master@{#33708}

Powered by Google App Engine
This is Rietveld 408576698