Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166053003: Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 2). (Closed)

Created:
6 years, 10 months ago by Yoyo Zhou
Modified:
6 years, 10 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), extensions-reviews_chromium.org, Lei Zhang, tommycli, Greg Billock, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 2). Follows part 1: https://chromiumcodereview.appspot.com/171813010/ BUG=309909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253187

Patch Set 1 #

Patch Set 2 : browser_context_ #

Total comments: 2

Patch Set 3 : | #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -212 lines) Patch
M chrome/browser/extensions/api/font_settings/font_settings_api.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_api.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.h View 1 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.h View 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/input/input.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api.cc View 1 4 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/messaging/incognito_connectability.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/incognito_connectability.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 15 chunks +39 lines, -37 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting_api.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.h View 1 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 5 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
Yoyo Zhou
6 years, 10 months ago (2014-02-20 23:20:18 UTC) #1
James Cook
LGTM with tiny nit https://chromiumcodereview.appspot.com/166053003/diff/30001/chrome/browser/extensions/api/messaging/incognito_connectability.h File chrome/browser/extensions/api/messaging/incognito_connectability.h (right): https://chromiumcodereview.appspot.com/166053003/diff/30001/chrome/browser/extensions/api/messaging/incognito_connectability.h#newcode53 chrome/browser/extensions/api/messaging/incognito_connectability.h:53: // Returns the IncognitoConnectability object ...
6 years, 10 months ago (2014-02-21 00:14:44 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-21 08:47:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-21 08:47:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 11:31:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=267717
6 years, 10 months ago (2014-02-21 11:31:58 UTC) #6
Yoyo Zhou
https://codereview.chromium.org/166053003/diff/30001/chrome/browser/extensions/api/messaging/incognito_connectability.h File chrome/browser/extensions/api/messaging/incognito_connectability.h (right): https://codereview.chromium.org/166053003/diff/30001/chrome/browser/extensions/api/messaging/incognito_connectability.h#newcode53 chrome/browser/extensions/api/messaging/incognito_connectability.h:53: // Returns the IncognitoConnectability object for |profile|. |profile| must ...
6 years, 10 months ago (2014-02-21 17:17:06 UTC) #7
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-21 17:17:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-21 17:18:47 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:23:16 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:23:16 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:23:17 UTC) #12
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:23:18 UTC) #13
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 10 months ago (2014-02-21 19:31:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-21 19:34:22 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 23:36:58 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268171
6 years, 10 months ago (2014-02-21 23:36:58 UTC) #17
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-24 21:36:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-24 21:37:30 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-25 01:31:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-25 07:32:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-25 09:10:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-25 09:27:30 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/166053003/80001
6 years, 10 months ago (2014-02-25 13:36:43 UTC) #24
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 17:47:57 UTC) #25
Message was sent while issue was closed. 
Change committed as 253187

Powered by Google App Engine
This is Rietveld 408576698