core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp - Issue 1660523003: Complete unit tests for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

Issue 1660523003: Complete unit tests for CPDF_Array (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Address more comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

index 813c18a4c5c0b7e9b8fe53e6322e93500af6fdb1..5f8b0752966e0d32921bb5f367a1b797e21c4230 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

@@ -454,10 +454,10 @@ void CPDF_Dictionary::SetAtRect(const CFX_ByteStringC& key,

void CPDF_Dictionary::SetAtMatrix(const CFX_ByteStringC& key,

const CFX_Matrix& matrix) {

CPDF_Array* pArray = new CPDF_Array;

- pArray->AddNumber16(matrix.a);

- pArray->AddNumber16(matrix.b);

- pArray->AddNumber16(matrix.c);

- pArray->AddNumber16(matrix.d);

+ pArray->AddNumber(matrix.a);

+ pArray->AddNumber(matrix.b);

+ pArray->AddNumber(matrix.c);

+ pArray->AddNumber(matrix.d);

pArray->AddNumber(matrix.e);

pArray->AddNumber(matrix.f);

SetAt(key, pArray);