webkit/plugins/ppapi/resource_creation_impl.h - Issue 16605006: Clean up Pepper ImageData resource class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/resource_creation_impl.h

Issue 16605006: Clean up Pepper ImageData resource class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add NOTREACHED if creating PlatformImageData in NaCl. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/resource_creation_impl.h

diff --git a/webkit/plugins/ppapi/resource_creation_impl.h b/webkit/plugins/ppapi/resource_creation_impl.h

index 5ced02322f1b56fb7b1b8c7f5d29e6b99550a14a..0303a537d17c2cc36f46dec6c94293ca0b3ae647 100644

--- a/webkit/plugins/ppapi/resource_creation_impl.h

+++ b/webkit/plugins/ppapi/resource_creation_impl.h

@@ -58,14 +58,12 @@ class WEBKIT_PLUGINS_EXPORT ResourceCreationImpl

PP_Resource share_context,

const int32_t* attrib_list) OVERRIDE;

virtual PP_Resource CreateHostResolverPrivate(PP_Instance instance) OVERRIDE;

- virtual PP_Resource CreateImageData(PP_Instance instance,

- PP_ImageDataFormat format,

- const PP_Size* size,

- PP_Bool init_to_zero) OVERRIDE;

- virtual PP_Resource CreateImageDataNaCl(PP_Instance instance,

- PP_ImageDataFormat format,

- const PP_Size* size,

- PP_Bool init_to_zero) OVERRIDE;

+ virtual PP_Resource CreateImageData(

+ PP_Instance instance,

+ ::ppapi::PPB_ImageData_Shared::ImageDataType type,

+ PP_ImageDataFormat format,

+ const PP_Size* size,

+ PP_Bool init_to_zero) OVERRIDE;

virtual PP_Resource CreateIMEInputEvent(PP_Instance instance,

PP_InputEvent_Type type,

PP_TimeTicks time_stamp,