Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2308)

Unified Diff: ppapi/proxy/video_source_resource.cc

Issue 16605006: Clean up Pepper ImageData resource class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Linux, allow both kinds of ImageData on host side. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/video_source_resource.cc
diff --git a/ppapi/proxy/video_source_resource.cc b/ppapi/proxy/video_source_resource.cc
index 0c3b192fb983de754ffe414254036444d38ba489..f6c5fdc41db100166635c0e09ebcb810f2b0f011 100644
--- a/ppapi/proxy/video_source_resource.cc
+++ b/ppapi/proxy/video_source_resource.cc
@@ -111,13 +111,14 @@ void VideoSourceResource::OnPluginMsgGetFrameComplete(
frame->image_data = 0;
#elif defined(TOOLKIT_GTK)
frame->image_data =
- (new ImageData(image_data, image_desc, fd))->GetReference();
+ (new PlatformImageData(image_data, image_desc, fd))->GetReference();
dmichael (off chromium) 2013/06/10 18:07:29 Does this case still make sense with this CL? I th
bbudge 2013/06/10 23:28:37 Right, there's a follow on CL that exposes the Med
#elif defined(OS_LINUX) || defined(OS_WIN) || defined(OS_MACOSX)
base::SharedMemoryHandle handle;
if (!reply_params.TakeSharedMemoryHandleAtIndex(0, &handle))
frame->image_data = 0;
frame->image_data =
- (new ImageData(image_data, image_desc, handle))->GetReference();
+ (new PlatformImageData(
+ image_data, image_desc, handle))->GetReference();
#else
#error Not implemented.
#endif

Powered by Google App Engine
This is Rietveld 408576698