Clean up Pepper ImageData resource class.

ppapi/thunk/ppb_image_data_thunk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // From ppb_image_data.idl modified Thu Apr 25 14:42:27 2013.
 
 #include <string.h>
 
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/ppb_image_data.h"
@@ skipping 21 matching lines @@
 }
 
 PP_Resource Create(PP_Instance instance,
                    PP_ImageDataFormat format,
                    const struct PP_Size* size,
                    PP_Bool init_to_zero) {
   VLOG(4) << "PPB_ImageData::Create()";
   EnterResourceCreation enter(instance);
   if (enter.failed())
     return 0;
-  return enter.functions()->CreateImageData(instance,
-                                            format,
-                                            size,
-                                            init_to_zero);
+  return enter.functions()->CreateImageDataPlatform(instance,
+                                                    format,
+                                                    size,
+                                                    init_to_zero);

[dmichael (off chromium), 2013/06/10 18:07:29]

I think here you'll need to do conditional compilation to make NaCl use
CreateImageDataSimple?

This also brings up the question of how the plugin draws frames. Does it use
what it's given, or does it have to create a new one? If it's creating a new
one, in the trusted case, it will be creating & sending "platform" image datas,
while it is receiving "simple" ones. I don't actually see any harm in that, but
it is a little odd.

[bbudge, 2013/06/10 23:28:37]

Done.

Hopefully it will be a NaCl plugin that actually ships.

 }
 
 PP_Bool IsImageData(PP_Resource image_data) {
   VLOG(4) << "PPB_ImageData::IsImageData()";
   EnterResource<PPB_ImageData_API> enter(image_data, false);
   return PP_FromBool(enter.succeeded());
 }
 
 PP_Bool Describe(PP_Resource image_data, struct PP_ImageDataDesc* desc) {
   VLOG(4) << "PPB_ImageData::Describe()";
@@ skipping 32 matching lines @@
 };
 
 }  // namespace
 
 const PPB_ImageData_1_0* GetPPB_ImageData_1_0_Thunk() {
   return &g_ppb_imagedata_thunk_1_0;
 }
 
 }  // namespace thunk
 }  // namespace ppapi