Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1660483002: Make MockVideoSource use rtc::VideoSinkInterface. (Closed)

Created:
4 years, 10 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 10 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MockVideoSource use rtc::VideoSinkInterface. BUG=webrtc:5426 Committed: https://crrev.com/278af1bae50f36ad2fffb4c0d15c4dd613606ba2 Cr-Commit-Position: refs/heads/master@{#372955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-chromium (ooo August 14)
When this is landed, the too ugly backwards-compatibility cruft in webrtc's VideoSourceInterface can be deleted.
4 years, 10 months ago (2016-02-02 13:28:13 UTC) #2
perkj_chrome
lgtm
4 years, 10 months ago (2016-02-02 14:42:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660483002/1
4 years, 10 months ago (2016-02-02 14:42:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 16:13:23 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 16:15:21 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/278af1bae50f36ad2fffb4c0d15c4dd613606ba2
Cr-Commit-Position: refs/heads/master@{#372955}

Powered by Google App Engine
This is Rietveld 408576698