components/autofill/content/renderer/autofill_agent.h - Issue 166043006: Add password manager autocomplete suggestion when a username element in clicked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 166043006: Add password manager autocomplete suggestion when a username element in clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase on ToT Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.h

diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h

index aa3841348b6a94dcc18a424efad1e93c54184515..8623ca06865113b5dcaf2066a8497a04ab37eeee 100644

--- a/components/autofill/content/renderer/autofill_agent.h

+++ b/components/autofill/content/renderer/autofill_agent.h

@@ -141,11 +141,18 @@ class AutofillAgent : public content::RenderViewObserver,

// |datalist_only| specifies whether all of <datalist> suggestions and no

// autofill suggestions are shown. |autofill_on_empty_values| and

// |requires_caret_at_end| are ignored if |datalist_only| is true.

+ // |show_full_suggestion_list| specifies that all autofill suggestions should

+ // be shown and none should be elided because of the current value of

+ // |element| (relevant for inline autocomplete).

+ // |show_password_suggestions_only| specifies that only show a suggestions box

+ // if |element| is part of a password form, otherwise show no suggestions.

void ShowSuggestions(const blink::WebFormControlElement& element,

bool autofill_on_empty_values,

bool requires_caret_at_end,

bool display_warning_if_disabled,

- bool datalist_only);

+ bool datalist_only,

+ bool show_full_suggestion_list,

+ bool show_password_suggestions_only);

// Queries the browser for Autocomplete and Autofill suggestions for the given

// |element|.

@@ -245,6 +252,7 @@ class AutofillAgent : public content::RenderViewObserver,

FRIEND_TEST_ALL_PREFIXES(

PasswordAutofillAgentTest,

PasswordAutofillTriggersOnChangeEventsWaitForUsername);

+ FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest, CredentialsOnClick);

FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest,

NoCancelOnMainFrameNavigateAfterDone);

FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest,