Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 166043006: Add password manager autocomplete suggestion when a username element in clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed a comment and cleaned up a browser test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index 32d7b752f8807047487a6e43d8947a2f97aa5c7a..0987bf57f673f6ac75da109b9d5cbdd822e2baf3 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -140,11 +140,18 @@ class AutofillAgent : public content::RenderViewObserver,
// |datalist_only| specifies whether all of <datalist> suggestions and no
// autofill suggestions are shown. |autofill_on_empty_values| and
// |requires_caret_at_end| are ignored if |datalist_only| is true.
+ // |show_full_suggestion_list| specifies that all autofill suggestions should
+ // be shown and none should be elided because of the current value of
+ // |element| (relevant for inline autocomplete).
+ // |show_password_suggestions_only| specifies that only show a suggestions box
+ // if |element| is part of a password form, otherwise show no suggestions.
void ShowSuggestions(const blink::WebInputElement& element,
bool autofill_on_empty_values,
bool requires_caret_at_end,
bool display_warning_if_disabled,
- bool datalist_only);
+ bool datalist_only,
+ bool show_full_suggestion_list,
+ bool show_password_suggestions_only);
// Queries the browser for Autocomplete and Autofill suggestions for the given
// |element|.
@@ -243,6 +250,7 @@ class AutofillAgent : public content::RenderViewObserver,
FRIEND_TEST_ALL_PREFIXES(
PasswordAutofillAgentTest,
PasswordAutofillTriggersOnChangeEventsWaitForUsername);
+ FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest, AllCredentialsOnClick);
DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
};

Powered by Google App Engine
This is Rietveld 408576698