Add password manager autocomplete suggestion when a username element in clicked.

components/autofill/content/renderer/autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 122 matching lines @@
   // when |element| contains no text.
   // |requires_caret_at_end| specifies whether suggestions should be shown when
   // the caret is not after the last character in |element|.
   // |display_warning_if_disabled| specifies whether a warning should be
   // displayed to the user if Autofill has suggestions available, but cannot
   // fill them because it is disabled (e.g. when trying to fill a credit card
   // form on a non-secure website).
   // |datalist_only| specifies whether all of <datalist> suggestions and no
   // autofill suggestions are shown. |autofill_on_empty_values| and
   // |requires_caret_at_end| are ignored if |datalist_only| is true.
+  // |show_full_suggestion_list| specifies that all autofill suggestions should
+  // be shown and none should be elided because of the current value of
+  // |element| (relevant for inline autocomplete).
+  // |show_password_suggestions_only| specifies that only show a suggestions box
+  // if |element| is part of a password form, otherwise show no suggestions.
   void ShowSuggestions(const blink::WebInputElement& element,
                        bool autofill_on_empty_values,
                        bool requires_caret_at_end,
                        bool display_warning_if_disabled,
-                       bool datalist_only);
+                       bool datalist_only,
+                       bool show_full_suggestion_list,
+                       bool show_password_suggestions_only);

[Garrett Casto, 2014/02/24 23:45:09]

This scares me a little, as it seems pretty easy to switch some of these around
on accident. But it was like this before, so I guess as long as we unit test
well enough it should be okay.

[jww, 2014/03/05 02:11:49]

I agree, although I'm not sure I see a better alternative.

 
   // Queries the browser for Autocomplete and Autofill suggestions for the given
   // |element|.
   void QueryAutofillSuggestions(const blink::WebInputElement& element,
                                 bool display_warning_if_disabled,
                                 bool datalist_only);
 
   // Sets the element value to reflect the selected |suggested_value|.
   void AcceptDataListSuggestion(const base::string16& suggested_value);
 
@@ skipping 80 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(
       PasswordAutofillAgentTest,
       PasswordAutofillTriggersOnChangeEventsWaitForUsername);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_