Add password manager autocomplete suggestion when a username element in clicked.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 271 matching lines @@
   Send(new AutofillHostMsg_RequestAutocomplete(routing_id(), form_data, url));
 }
 
 void AutofillAgent::setIgnoreTextChanges(bool ignore) {
   ignore_text_changes_ = ignore;
 }
 
 void AutofillAgent::InputElementClicked(const WebInputElement& element,
                                         bool was_focused,
                                         bool is_focused) {
-  if (was_focused)
-    ShowSuggestions(element, true, false, true, false);
+  ShowSuggestions(element, true, false, true, false, true);

[Garrett Casto, 2014/02/19 21:20:19]

Ilya, are you okay with Autofill also showing on first click? I don't remember
this coming up explicitly.

I'm also not sure if this does exactly what we want. It seems like we want to
show all suggestions in the case where the user wants to change an autofilled
username, not if they click on the field again to move the cursor or re-select
the field after typing in their preferred username. I think that we want this to
be more like "show_all_if_autofilled". Does that sound right?

[jww, 2014/02/19 21:56:48]

I'm worried that would be hard-to-understand behavior. My thought is that a
click means full list, no more no less. I'd hate for users to have to understand
a more complex UI experience.

I'm cool with the tabbing idea as well. Any other thoughts about that?

[jww, 2014/02/19 22:14:39]

Obviously we're still waiting for comments on the tabbing idea, but looking into
it briefly, it appears it would be harder to get that right than I originally
thought. How would you feel about tabbing-to-get-menu as a separate CL?

Right now, you can still get the effect by erasing the username and getting the
full list, which is obviously not as convenient as just tabbing, but at least
it's possible.

[jww, 2014/02/21 02:43:28]

My bad. I misunderstood your point in a similar way to Ilya. I've fixed this
now, I think.

 }
 
 void AutofillAgent::InputElementLostFocus() {
   HideAutofillUI();
 }
 
 void AutofillAgent::textFieldDidEndEditing(const WebInputElement& element) {
   password_autofill_agent_->TextFieldDidEndEditing(element);
   has_shown_autofill_popup_for_current_edit_ = false;
   Send(new AutofillHostMsg_DidEndTextFieldEditing(routing_id()));
@@ skipping 28 matching lines @@
   if (password_generation_agent_ &&
       password_generation_agent_->TextDidChangeInTextField(element)) {
     return;
   }
 
   if (password_autofill_agent_->TextDidChangeInTextField(element)) {
     element_ = element;
     return;
   }
 
-  ShowSuggestions(element, false, true, false, false);
+  ShowSuggestions(element, false, true, false, false, false);
 
   FormData form;
   FormFieldData field;
   if (FindFormAndFieldForInputElement(element, &form, &field, REQUIRE_NONE)) {
     Send(new AutofillHostMsg_TextFieldDidChange(routing_id(), form, field,
                                                 base::TimeTicks::Now()));
   }
 }
 
 void AutofillAgent::textFieldDidReceiveKeyDown(const WebInputElement& element,
                                                const WebKeyboardEvent& event) {
   if (password_autofill_agent_->TextFieldHandlingKeyDown(element, event)) {
     element_ = element;
     return;
   }
 
   if (event.windowsKeyCode == ui::VKEY_DOWN ||
       event.windowsKeyCode == ui::VKEY_UP)
-    ShowSuggestions(element, true, true, true, false);
+    ShowSuggestions(element, true, true, true, false, false);
 }
 
 void AutofillAgent::openTextDataListChooser(const WebInputElement& element) {
-    ShowSuggestions(element, true, false, false, true);
+  ShowSuggestions(element, true, false, false, true, false);
 }
 
 void AutofillAgent::AcceptDataListSuggestion(
     const base::string16& suggested_value) {
   base::string16 new_value = suggested_value;
   // If this element takes multiple values then replace the last part with
   // the suggestion.
   if (element_.isMultiple() &&
       element_.formControlType() == WebString::fromUTF8("email")) {
     std::vector<base::string16> parts;
@@ skipping 110 matching lines @@
   in_flight_request_form_.reset();
 }
 
 void AutofillAgent::OnPageShown() {
 }
 
 void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
                                     bool display_warning_if_disabled,
-                                    bool datalist_only) {
+                                    bool datalist_only,
+                                    bool show_all) {
   if (!element.isEnabled() || element.isReadOnly() || !element.isTextField() ||
       element.isPasswordField())
     return;
   if (!datalist_only && !element.suggestedValue().isEmpty())
     return;
 
   // Don't attempt to autofill with values that are too large or if filling
   // criteria are not met.
   WebString value = element.editingValue();
   if (!datalist_only &&
       (value.length() > kMaxDataLength ||
        (!autofill_on_empty_values && value.isEmpty()) ||
        (requires_caret_at_end &&
         (element.selectionStart() != element.selectionEnd() ||
          element.selectionEnd() != static_cast<int>(value.length()))))) {
     // Any popup currently showing is obsolete.
     HideAutofillUI();
     return;
   }
 
   element_ = element;
-  if (password_autofill_agent_->ShowSuggestions(element))
+  if (password_autofill_agent_->ShowSuggestions(element, show_all))
     return;
 
   // If autocomplete is disabled at the field level, ensure that the native
   // UI won't try to show a warning, since that may conflict with a custom
   // popup. Note that we cannot use the WebKit method element.autoComplete()
   // as it does not allow us to distinguish the case where autocomplete is
   // disabled for *both* the element and for the form.
   const base::string16 autocomplete_attribute =
       element.getAttribute("autocomplete");
   if (LowerCaseEqualsASCII(autocomplete_attribute, "off"))
@@ skipping 101 matching lines @@
     // Only monitors dynamic forms created in the top frame. Dynamic forms
     // inserted in iframes are not captured yet.
     if (!frame->parent()) {
       password_autofill_agent_->OnDynamicFormsSeen(frame);
       return;
     }
   }
 }
 
 }  // namespace autofill