Mojo C++ bindings: Rename InterfaceInfoPtr -> InterfaceHandle

Mojo C++ bindings: Rename InterfaceInfoPtr -> InterfaceHandle

R=jamesr@chromium.org, viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/dac048a330174d4bb4346b645cbb8fe66d24e323

[vardhan, 2016-02-03 22:13:59]

PTAL.

Also okay with suggestions for using a different name than InterfaceHandle<>,
InterfaceDescriptor<> being a good contender.

Just note that going forward, we will operate by using the <MyService>Handle
typedef, so whatever the name change for InterfacePtrInfo is, we have to live
with the new typedefs.  They will also be annoying to change moving forward, so
lets settle this now!

[jamesr, 2016-02-03 22:42:57]

I think the thread was converging on Descriptor instead.  I'm not super
opinionated on Handle vs Descriptor but we should make sure everyone likes the
name we pick.

lgtm on the patch itself % the actual name.

https://codereview.chromium.org/1660403003/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/bindings_serialization.h (right):

https://codereview.chromium.org/1660403003/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/bindings_serialization.h:82: InterfaceHandle<T>
info = input.PassInterface();
it's weird that PassInterface() returns a InterfaceHandle.  It's also weird that
it used to return InterfacePtrInfo, too.

[vardhan, 2016-02-03 22:57:55]

Looks like '<Interface>Descriptor' as a typedef is already causing some name
collisions: We have an AudioTrack /and/ an AudioTrackDescriptor.

I think InterfaceHandle is a safe option for now.  If anyone feels strongly
enough, we can make a change in the future.  For now, lets get this in since
it's blocking some other CLs.


On 2016/02/03 22:42:57, jamesr wrote:
> I think the thread was converging on Descriptor instead.  I'm not super
> opinionated on Handle vs Descriptor but we should make sure everyone likes the
> name we pick.
> 
> lgtm on the patch itself % the actual name.
> 
>
https://codereview.chromium.org/1660403003/diff/20001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/lib/bindings_serialization.h (right):
> 
>
https://codereview.chromium.org/1660403003/diff/20001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/lib/bindings_serialization.h:82: InterfaceHandle<T>
> info = input.PassInterface();
> it's weird that PassInterface() returns a InterfaceHandle.  It's also weird
that
> it used to return InterfacePtrInfo, too.

[vardhan, 2016-02-04 01:16:59]

Description was changed from

==========
Mojo C++ bindings: Rename InterfaceInfoPtr -> InterfaceHandle

R=viettrungluu@chromium.org,jamesr@chromium.org
==========

to

==========
Mojo C++ bindings: Rename InterfaceInfoPtr -> InterfaceHandle

R=jamesr@chromium.org, viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/dac048a330174d4bb4346b645cb...
==========

[vardhan, 2016-02-04 01:17:00]

Committed patchset #2 (id:20001) manually as
dac048a330174d4bb4346b645cbb8fe66d24e323 (presubmit successful).

[viettrungluu, 2016-02-05 17:41:55]

On 2016/02/03 22:42:57, jamesr wrote:
> I think the thread was converging on Descriptor instead.  I'm not super
> opinionated on Handle vs Descriptor but we should make sure everyone likes the
> name we pick.

I'm OK with Handle, I guess. We should probably make InterfaceHandle look/act
more like things that are actually handles (in particular, more like
ScopedHandle, etc.).

> 
> lgtm on the patch itself % the actual name.
> 
>
https://codereview.chromium.org/1660403003/diff/20001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/lib/bindings_serialization.h (right):
> 
>
https://codereview.chromium.org/1660403003/diff/20001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/lib/bindings_serialization.h:82: InterfaceHandle<T>
> info = input.PassInterface();
> it's weird that PassInterface() returns a InterfaceHandle.  It's also weird
that
> it used to return InterfacePtrInfo, too.

Probably we should rename it "PassInterfaceHandle" (or maybe just
"PassHandle"?).