Chromium Code Reviews

Unified Diff: third_party/WebKit/public/platform/Platform.h

Issue 1660383002: Refactoring: Move some classes from content/child to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Syntax Error :-( Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: third_party/WebKit/public/platform/Platform.h
diff --git a/third_party/WebKit/public/platform/Platform.h b/third_party/WebKit/public/platform/Platform.h
index 784aa7eb0fb74ccdaaffcba5f33e85c7d258468d..92d33fc1c55ba8ee9686e9fa0aca11095d3341f9 100644
--- a/third_party/WebKit/public/platform/Platform.h
+++ b/third_party/WebKit/public/platform/Platform.h
@@ -458,10 +458,10 @@ public:
// registerMemoryDumpProvider() method. |name| is used for debugging
// (duplicates are allowed) and must be a long-lived C string.
// See crbug.com/458295 for design docs.
- virtual void registerMemoryDumpProvider(blink::WebMemoryDumpProvider*, const char* name) { }
+ BLINK_PLATFORM_EXPORT void registerMemoryDumpProvider(blink::WebMemoryDumpProvider*, const char* name);
kinuko 2016/02/04 11:25:34 Does this change mean that they're also called by
hajimehoshi 2016/02/04 12:17:52 Compiling fails without this: this is called only
// Must be called on the thread that called registerMemoryDumpProvider().
- virtual void unregisterMemoryDumpProvider(blink::WebMemoryDumpProvider*) { }
+ BLINK_PLATFORM_EXPORT void unregisterMemoryDumpProvider(blink::WebMemoryDumpProvider*);
class TraceLogEnabledStateObserver {
public:
@@ -474,9 +474,6 @@ public:
virtual void addTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
virtual void removeTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
- // Returns a newly allocated WebProcessMemoryDump instance.
- virtual blink::WebProcessMemoryDump* createProcessMemoryDump() { return nullptr; }
-
typedef uint64_t WebMemoryAllocatorDumpGuid;
// Returns guid corresponding to the given string (the hash value) for

Powered by Google App Engine