third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp - Issue 1660383002: Refactoring: Move some classes from content/child to platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

Issue 1660383002: Refactoring: Move some classes from content/child to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move implementation from static functions to member functions as default impl Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/WebProcessMemoryDumpImpl.h ('K') | « third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

index cd4259addc609904923f6176edb33d18cd958e03..7c10a2498e3708e24e27840de2ed8889ec38d872 100644

--- a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

+++ b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

@@ -4,8 +4,8 @@

#include "platform/heap/BlinkGCMemoryDumpProvider.h"

+#include "platform/WebProcessMemoryDumpImpl.h"

#include "public/platform/Platform.h"

-#include "public/platform/WebProcessMemoryDump.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "wtf/Threading.h"

@@ -13,7 +13,7 @@ namespace blink {

TEST(BlinkGCDumpProviderTest, MemoryDump)

{

- OwnPtr<WebProcessMemoryDump> dump = adoptPtr(Platform::current()->createProcessMemoryDump());

+ OwnPtr<WebProcessMemoryDump> dump = adoptPtr(new WebProcessMemoryDumpImpl());

ASSERT(dump);

BlinkGCMemoryDumpProvider::instance()->onMemoryDump(WebMemoryDumpLevelOfDetail::Detailed, dump.get());

ASSERT(dump->getMemoryAllocatorDump(String::format("blink_gc")));