Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: content/child/blink_platform_impl.cc

Issue 1660383002: Refactoring: Move some classes from content/child to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: kinuko's review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/blink_platform_impl.cc
diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc
index 7671d05c73025371a1b373e24350cfbf2e8f0636..84319860b28885f1426ef30cea12bedbc9d5dc1c 100644
--- a/content/child/blink_platform_impl.cc
+++ b/content/child/blink_platform_impl.cc
@@ -51,8 +51,6 @@
#include "content/child/push_messaging/push_provider.h"
#include "content/child/thread_safe_sender.h"
#include "content/child/web_discardable_memory_impl.h"
-#include "content/child/web_memory_dump_provider_adapter.h"
-#include "content/child/web_process_memory_dump_impl.h"
#include "content/child/web_url_loader_impl.h"
#include "content/child/web_url_request_util.h"
#include "content/child/websocket_bridge.h"
@@ -603,30 +601,12 @@ void BlinkPlatformImpl::histogramEnumeration(
void BlinkPlatformImpl::registerMemoryDumpProvider(
blink::WebMemoryDumpProvider* wmdp, const char* name) {
- WebMemoryDumpProviderAdapter* wmdp_adapter =
- new WebMemoryDumpProviderAdapter(wmdp);
- bool did_insert =
- memory_dump_providers_.add(wmdp, make_scoped_ptr(wmdp_adapter)).second;
- if (!did_insert)
- return;
- wmdp_adapter->set_is_registered(true);
- base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- wmdp_adapter, name, base::ThreadTaskRunnerHandle::Get());
+ blink::Platform::registerMemoryDumpProviderImpl(wmdp, name);
}
void BlinkPlatformImpl::unregisterMemoryDumpProvider(
blink::WebMemoryDumpProvider* wmdp) {
- scoped_ptr<WebMemoryDumpProviderAdapter> wmdp_adapter =
- memory_dump_providers_.take_and_erase(wmdp);
- if (!wmdp_adapter)
- return;
- base::trace_event::MemoryDumpManager::GetInstance()->UnregisterDumpProvider(
- wmdp_adapter.get());
- wmdp_adapter->set_is_registered(false);
-}
-
-blink::WebProcessMemoryDump* BlinkPlatformImpl::createProcessMemoryDump() {
- return new WebProcessMemoryDumpImpl();
+ blink::Platform::unregisterMemoryDumpProviderImpl(wmdp);
}
blink::Platform::WebMemoryAllocatorDumpGuid

Powered by Google App Engine
This is Rietveld 408576698