Refactoring: Move some classes from content/child to platform

third_party/WebKit/public/platform/Platform.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 440 matching lines @@
     // Record to a RAPPOR privacy-preserving metric, see: https://www.chromium.org/developers/design-documents/rappor.
     // recordRappor records a sample string, while recordRapporURL records the domain and registry of a url.
     virtual void recordRappor(const char* metric, const WebString& sample) { }
     virtual void recordRapporURL(const char* metric, const blink::WebURL& url) { }
 
     // Registers a memory dump provider. The WebMemoryDumpProvider::onMemoryDump
     // method will be called on the same thread that called the
     // registerMemoryDumpProvider() method. |name| is used for debugging
     // (duplicates are allowed) and must be a long-lived C string.
     // See crbug.com/458295 for design docs.
-    virtual void registerMemoryDumpProvider(blink::WebMemoryDumpProvider*, const char* name) { }
+    BLINK_PLATFORM_EXPORT void registerMemoryDumpProvider(blink::WebMemoryDumpProvider*, const char* name);

[kinuko, 2016/02/04 13:15:54]

If these are not called outside blink I don't think they should be in public/;
please move them from public/platform to Source/platform.

Also I don't think they need to be kept as Platform:: methods, they could be
just moved to a separate utility file in Source/platform, couldn't they?  (I
haven't looked at the callsite yet though)

[hajimehoshi, 2016/02/05 07:41:54]

Done.

[hajimehoshi, 2016/02/05 07:41:54]

I've just now found that TestBlinkWebUnitTestSupport, which is another class
inheriting Platform, must have empty (un)registerMemoryDumpProvider
implementation . This means The actual implementation BlinkPlatformImpl in
Chromium side should call this logic in Blink. I'll change their actual
implementation as static functions and leave BLINK_PLATFORM_EXPORT for the new
functions. Sorry for the confusion.

 
     // Must be called on the thread that called registerMemoryDumpProvider().
-    virtual void unregisterMemoryDumpProvider(blink::WebMemoryDumpProvider*) { }
+    BLINK_PLATFORM_EXPORT void unregisterMemoryDumpProvider(blink::WebMemoryDumpProvider*);
 
     class TraceLogEnabledStateObserver {
     public:
         virtual ~TraceLogEnabledStateObserver() = default;
         virtual void onTraceLogEnabled() = 0;
         virtual void onTraceLogDisabled() = 0;
     };
 
     // Register or unregister a trace log state observer. Does not take ownership.
     virtual void addTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
     virtual void removeTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
 
-    // Returns a newly allocated WebProcessMemoryDump instance.
-    virtual blink::WebProcessMemoryDump* createProcessMemoryDump() { return nullptr; }
-
     typedef uint64_t WebMemoryAllocatorDumpGuid;
 
     // Returns guid corresponding to the given string (the hash value) for
     // creating a WebMemoryAllocatorDump.
     virtual WebMemoryAllocatorDumpGuid createWebMemoryAllocatorDumpGuid(const WebString& guidStr) { return 0; }
 
     // GPU ----------------------------------------------------------------
     //
     // May return null if GPU is not supported.
     // Returns newly allocated and initialized offscreen WebGraphicsContext3D instance.
@@ skipping 150 matching lines @@
 protected:
     BLINK_PLATFORM_EXPORT Platform();
     virtual ~Platform() { }
 
     WebThread* m_mainThread;
 };
 
 } // namespace blink
 
 #endif