third_party/WebKit/Source/platform/DEPS - Issue 1660383002: Refactoring: Move some classes from content/child to platform

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/DEPS

Issue 1660383002: Refactoring: Move some classes from content/child to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move a new comment in PRESUBMIT.py Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/PRESUBMIT.py ('K') | « third_party/WebKit/Source/DEPS ('k') | third_party/WebKit/Source/platform/WebMemoryAllocatorDumpImpl.h » ('j') | third_party/WebKit/public/platform/Platform.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # To whitelist base/ stuff Blink is allowed to include, we list up all	2 # To whitelist base/ stuff Blink is allowed to include, we list up all

3 # directories and files instead of writing 'base/'.	3 # directories and files instead of writing 'base/'.

4 "+base/json",	4 "+base/json",

5 "+base/location.h",	5 "+base/location.h",

6 "+base/metrics/histogram.h",	6 "+base/metrics/histogram.h",

7 "+base/metrics/sparse_histogram.h",	7 "+base/metrics/sparse_histogram.h",

8 "+base/memory",	8 "+base/memory",
	kinuko 2016/02/04 13:15:54 If including base/memory/scoped_ptr doesn't make c If including base/memory/scoped_ptr doesn't make compile fail because of this line could we explicitly blacklist banned files too? Like: # These files are explicitly banned as they conflict with wtf templates. "-base/memory/scoped_ptr.h", "-base/memory/scoped_vector.h", ... Nico 2016/02/04 15:08:15 (If the "could we" means "is it possible", then ye Show quoted text On 2016/02/04 13:15:54, kinuko wrote: > If including base/memory/scoped_ptr doesn't make compile fail because of this > line could we explicitly blacklist banned files too? Like: > > # These files are explicitly banned as they conflict with wtf templates. > "-base/memory/scoped_ptr.h", > "-base/memory/scoped_vector.h", > ... (If the "could we" means "is it possible", then yes, we do this elsewhere: https://code.google.com/p/chromium/codesearch#chromium/src/content/DEPS&l=21)
9 "+base/sys_info.h",	9 "+base/sys_info.h",

	10 "+base/thread_task_runner_handle.h",
	kinuko 2016/02/04 13:15:54 This one's slightly questionable to me too, while This one's slightly questionable to me too, while it's probably safe it feels a bit confusing too...
10 "+base/time",	11 "+base/time",

11 "+base/trace_event",	12 "+base/trace_event",

12 "+base/values.h",	13 "+base/values.h",

13 "+mozilla",	14 "+mozilla",

14 "+platform",	15 "+platform",

15 "+public/platform",	16 "+public/platform",

16 "+skia/ext",	17 "+skia/ext",

17 "+third_party/khronos",	18 "+third_party/khronos",

18 "+third_party/skia",	19 "+third_party/skia",

19 "+ui/gfx",	20 "+ui/gfx",

20 "+url",	21 "+url",

21 "+webp",	22 "+webp",

22 "-bindings",	23 "-bindings",

23 "-core",	24 "-core",

24 "-modules",	25 "-modules",

25 ]	26 ]

OLD	NEW