chrome/android/java/res/layout/sync_custom_passphrase.xml - Issue 1660353002: Update account and sync management UX

Unified Diff: chrome/android/java/res/layout/sync_custom_passphrase.xml

Issue 1660353002: Update account and sync management UX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/add_circle_blue.png ('k') | chrome/android/java/res/layout/sync_passphrase_types.xml » ('j') | chrome/android/java/res/xml/sync_customization_preferences.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/sync_custom_passphrase.xml

diff --git a/chrome/android/java/res/layout/sync_custom_passphrase.xml b/chrome/android/java/res/layout/sync_custom_passphrase.xml

index 397f9df31e80600a47622cf5f94fbc1633cdd865..847c1bf1aa78caf936ba2baa3572d5e8252b13a1 100644

--- a/chrome/android/java/res/layout/sync_custom_passphrase.xml

+++ b/chrome/android/java/res/layout/sync_custom_passphrase.xml

@@ -5,17 +5,13 @@

<ScrollView

xmlns:android="http://schemas.android.com/apk/res/android"

+ xmlns:chrome="http://schemas.android.com/apk/res-auto"

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:overScrollMode="ifContentScrolls">

<LinearLayout

android:orientation="vertical"

style="@style/AlertDialogContent">

- <TextView

- android:layout_width="match_parent"

- android:layout_height="wrap_content"

- android:layout_marginBottom="25dp"

- android:text="@string/sync_custom_passphrase"/>

<org.chromium.chrome.browser.widget.AlertDialogEditText

android:id="@+id/passphrase"

android:hint="@string/sync_enter_custom_passphrase_hint"

@@ -32,5 +28,13 @@

android:inputType="textPassword"

android:singleLine="true"

android:imeOptions="actionDone" />

+ <TextView

+ android:id="@+id/custom_passphrase_instructions"

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content"

+ android:layout_marginBottom="25dp"

newt (away) 2016/02/16 23:05:01 Still seems like a lot of extra padding/margin. Do

May 2016/02/17 13:24:31 It does visually. I don't have any vizd for actual

newt (away) 2016/02/17 19:34:41 Ok. Sometimes counting pixels in GIMP is the best

+ android:layout_marginTop="25dp"

+ android:text="@string/sync_custom_passphrase"

+ chrome:helpContext="@string/help_context_clear_browsing_data" />

newt (away) 2016/02/16 23:05:01 Huh? chrome:helpContext is used for the LearnMoreP

May 2016/02/17 13:24:31 Ugh, missed this before uploading. Removed.

</LinearLayout>

</ScrollView>