Update account and sync management UX

chrome/android/java/src/org/chromium/chrome/browser/signin/SignOutDialogFragment.java

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SignOutDialogFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SignOutDialogFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SignOutDialogFragment.java
index f640189e232a6ced238dc868233e0660fd82bf95..3242a5e9c7297ba936d5e7087dabb4d0164ab3b9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SignOutDialogFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SignOutDialogFragment.java
@@ -11,6 +11,7 @@ import android.os.Bundle;
 import android.support.v7.app.AlertDialog;
 
 import org.chromium.chrome.R;
+import org.chromium.chrome.browser.profiles.ProfileAccountManagementMetrics;
 
 /**
  * Shows the dialog that explains the user the consequences of signing out of Chrome.
@@ -37,9 +38,16 @@ public class SignOutDialogFragment extends DialogFragment implements
     }
 
     private boolean mSignOutClicked;
+    private int mGaiaServiceType;

[newt (away), 2016/02/12 22:03:50]

This needs a comment explaining what the valid values are. Pointing the reader
to AccountManagementFragment.GAIA_SERVICE_TYPE_NONE would be sufficient.

[May, 2016/02/16 17:32:07]

Done.

 
     @Override
     public Dialog onCreateDialog(Bundle savedInstanceState) {
+        mGaiaServiceType = AccountManagementFragment.GAIA_SERVICE_TYPE_NONE;
+        if (getArguments() != null) {
+            mGaiaServiceType = getArguments().getInt(
+                    AccountManagementFragment.SHOW_GAIA_SERVICE_TYPE_EXTRA, mGaiaServiceType);

[newt (away), 2016/02/12 22:03:50]

Rather than reusing the value of
AccountManagementFragment.SHOW_GAIA_SERVICE_TYPE_EXTRA, I'd define a constant in
this file similar to SHOW_GAIA_SERVICE_TYPE_EXTRA. That'll make it clearer to
anyone who reads this file than SHOW_GAIA_SERVICE_TYPE_EXTRA is a valid extra
that can be passed to this fragment.

In general, I'm a bit wary of adding dependencies on AccountManagementFragment,
which is really supposed to be a UI class that consumes model data, but isn't
depended on by other UI classes. If you could move GAIA_SERVICE_TYPE_NONE to a
non-UI class, say, AccountManagementScreenHelper, that would make more sense. In
fact, AccountManagementScreenHelper already contains GAIA_SERVICE_TYPE_SIGNUP.

[May, 2016/02/16 17:32:07]

Done.

+        }
+
         String managementDomain = SigninManager.get(getActivity()).getManagementDomain();
         String message;
         if (managementDomain == null) {
@@ -51,7 +59,7 @@ public class SignOutDialogFragment extends DialogFragment implements
 
         return new AlertDialog.Builder(getActivity(), R.style.AlertDialogTheme)
                 .setTitle(R.string.signout_title)
-                .setPositiveButton(R.string.ok, this)
+                .setPositiveButton(R.string.signout_dialog_positive_button, this)
                 .setNegativeButton(R.string.cancel, this)
                 .setMessage(message)
                 .create();
@@ -60,6 +68,9 @@ public class SignOutDialogFragment extends DialogFragment implements
     @Override
     public void onClick(DialogInterface dialog, int which) {
         if (which == AlertDialog.BUTTON_POSITIVE) {
+            AccountManagementScreenHelper.logEvent(
+                    ProfileAccountManagementMetrics.SIGNOUT_SIGNOUT, mGaiaServiceType);
+
             mSignOutClicked = true;
             SignOutDialogListener targetFragment = (SignOutDialogListener) getTargetFragment();
             targetFragment.onSignOutClicked();
@@ -69,6 +80,9 @@ public class SignOutDialogFragment extends DialogFragment implements
     @Override
     public void onDismiss(DialogInterface dialog) {
         super.onDismiss(dialog);
+        AccountManagementScreenHelper.logEvent(
+                ProfileAccountManagementMetrics.SIGNOUT_CANCEL, mGaiaServiceType);
+
         SignOutDialogListener targetFragment = (SignOutDialogListener) getTargetFragment();
         targetFragment.onSignOutDialogDismissed(mSignOutClicked);
     }