Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java

Issue 1660353002: Update account and sync management UX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor formatting changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
index b81883042921b084a55477008b3422fe65fad913..832cded1641941588221ddf038e83b2e247cd410 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
@@ -21,11 +21,8 @@ import org.chromium.chrome.browser.profiles.ProfileDownloader;
import org.chromium.chrome.browser.signin.AccountManagementFragment;
import org.chromium.chrome.browser.signin.SigninManager;
import org.chromium.chrome.browser.signin.SigninManager.SignInAllowedObserver;
-import org.chromium.sync.signin.AccountManagerHelper;
import org.chromium.sync.signin.ChromeSigninController;
-import java.util.List;
-
/**
* A preference that displays "Sign in to Chrome" when the user is not sign in, and displays
* the user's name, email, and profile image when the user is signed in.
@@ -78,13 +75,8 @@ public class SignInPreference extends Preference implements SignInAllowedObserve
summary = getContext().getString(R.string.sign_in_to_chrome_summary);
fragment = null;
} else {
- List<String> accounts = AccountManagerHelper.get(getContext()).getGoogleAccountNames();
- if (accounts.size() == 1) {
- summary = accounts.get(0);
- } else {
- summary = getContext().getString(
- R.string.number_of_signed_in_accounts, accounts.size());
- }
+ summary = String.format(
+ getContext().getString(R.string.account_management_sync_summary), account.name);
fragment = AccountManagementFragment.class.getName();
title = AccountManagementFragment.getCachedUserName(account.name);
if (title == null) {

Powered by Google App Engine
This is Rietveld 408576698