Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 166033008: Support viewport in content_shell. (Closed)

Created:
6 years, 10 months ago by Zeeshan Qureshi
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Support viewport in content_shell. Viewport preferences are overridden even with the --enable-viewport flag passed in. BUG=343993 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/shell/common/webkit_test_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-14 20:19:43 UTC) #1
Zeeshan Qureshi
The CQ bit was unchecked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-14 20:19:44 UTC) #2
aelias_OOO_until_Jul13
lgtm
6 years, 10 months ago (2014-02-18 19:15:28 UTC) #3
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-18 19:16:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/166033008/1
6 years, 10 months ago (2014-02-18 19:17:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 19:31:33 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50745
6 years, 10 months ago (2014-02-18 19:31:34 UTC) #7
Zeeshan Qureshi
+jochen for OWNERS
6 years, 10 months ago (2014-02-18 19:52:46 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-19 17:30:11 UTC) #9
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-19 17:55:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/166033008/1
6 years, 10 months ago (2014-02-19 17:58:01 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 18:14:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-19 18:14:51 UTC) #13
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-19 18:19:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/166033008/1
6 years, 10 months ago (2014-02-19 18:37:07 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 18:43:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-19 18:43:28 UTC) #17
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-19 19:52:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/166033008/1
6 years, 10 months ago (2014-02-19 19:56:07 UTC) #19
Zeeshan Qureshi
The CQ bit was unchecked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-19 22:16:55 UTC) #20
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 10 months ago (2014-02-19 22:17:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/166033008/1
6 years, 10 months ago (2014-02-20 00:21:40 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 02:28:07 UTC) #23
Message was sent while issue was closed.
Change committed as 252161

Powered by Google App Engine
This is Rietveld 408576698