Clear the pending_and_current_web_ui_ if we reuse it.

Clear the pending_and_current_web_ui_ if we reuse it.

R=nasko@chromium.org
TBR=estade@chromium.org
BUG=330811
TEST=See bug comment 9 for repro steps.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251420

[Charlie Reis, 2014-02-14 19:18:11]

Evan, do you have a minute to review this?  It looks like you added
pending_and_current_web_ui_ in https://codereview.chromium.org/10154004, and I'd
like to make sure it's correct to clear it here.

I'm seeing if I can put together a test right now.

[Charlie Reis, 2014-02-14 19:34:55]

Ok, test added.

[nasko, 2014-02-14 19:50:45]

This is a very complex way to say "if we reuse ...", I agree we should simplify
this.

LGTM

[Charlie Reis, 2014-02-14 21:12:34]

Agreed.  I'll look into that separately, once we merge this fix to the branch. 
I'll move estade to the TBR, since this is looking good on the try jobs.

[Charlie Reis, 2014-02-14 21:14:14]

Committed patchset #2 manually as r251420 (presubmit successful).

[Evan Stade, 2014-02-14 21:29:14]

this patch is OK I guess, it's been a while since I made that change though. I
have to say I've confused myself with this code. Why didn't I just create a bool
|reuse_current_webui_as_pending_|?

[Charlie Reis, 2014-02-14 21:32:15]

On 2014/02/14 21:29:14, Evan Stade wrote:
> this patch is OK I guess, it's been a while since I made that change though. I
> have to say I've confused myself with this code. Why didn't I just create a
bool
> |reuse_current_webui_as_pending_|?

That was what I was thinking about trying next.  Let me know if any issues occur
to you in the meantime, and I'll see if it works out.

Thanks,
Charlie