Port Node's previousElementSibling() / nextElementSibling() to ElementTraversal

Port Node's previousElementSibling() / nextElementSibling() to ElementTraversal

Port Node's previousElementSibling() / nextElementSibling() to ElementTraversal
and update callers on native side to use ElementTraversal instead for
consistency.

R=adamk, eseidel

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167229

[Inactive, 2014-02-14 17:22:31]

https://codereview.chromium.org/166033005/diff/1/Source/core/dom/Node.cpp
File Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/166033005/diff/1/Source/core/dom/Node.cpp#new...
Source/core/dom/Node.cpp:2552: Element* Node::previousElementSibling() const
In a follow-up, I will drop these 2 methods from Node and move them to a
separate ChildNode.h header, as these are part of the ChildNode.idl supplemental
interface.

[adamk, 2014-02-14 17:42:44]

lgtm

[Inactive, 2014-02-14 20:47:34]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-14 20:47:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/166033005/80001

[commit-bot: I haz the power, 2014-02-14 22:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 22:42:00]

Failed to apply patch for Source/core/dom/Document.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Document.cpp
  Hunk #1 FAILED at 1378.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/dom/Document.cpp.rej

Patch:       Source/core/dom/Document.cpp
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index
fc96a78f0691f37a793a74b9fa6f80222c930ef8..da979b4c11319e109c9a53cbed1bcebd7ad590b6
100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -1378,7 +1378,7 @@ void Document::removeTitle(Element* titleElement)
     // FIXME: This is broken for SVG.
     // Update title based on first title element in the head, if one exists.
     if (HTMLElement* headElement = head()) {
-        for (Element* element = headElement->firstElementChild(); element;
element = element->nextElementSibling()) {
+        for (Element* element = ElementTraversal::firstWithin(*headElement);
element; element = ElementTraversal::nextSibling(*element)) {
             if (!element->hasTagName(titleTag))
                 continue;
             HTMLTitleElement* title = toHTMLTitleElement(element);

[Inactive, 2014-02-14 23:07:02]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-14 23:07:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/166033005/170001

[commit-bot: I haz the power, 2014-02-15 00:25:42]

Change committed as 167229