Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 16603005: Revert 152077 "[Resource Timing] Expose redirect timing information" (Closed)

Created:
7 years, 6 months ago by tkent
Modified:
7 years, 6 months ago
Reviewers:
Pan
CC:
blink-reviews
Visibility:
Public.

Description

Revert 152077 "[Resource Timing] Expose redirect timing information" It broke browser_tests and content_browsertests on all Debug bots. e.g. http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/11883/steps/content_browsertests/logs/CrossOriginRedirectBlocked ResourceDispatcherHostBrowserTest.CrossOriginRedirectBlocked: > ASSERTION FAILED: m_timing > ../../third_party/WebKit/Source/core/page/PerformanceResourceTiming.cpp(62) : WebCore::PerformanceResourceTiming::PerformanceResourceTiming(const WebCore::ResourceTimingInfo &, WebCore::Document *, double, double, bool, bool) > 1 0xc313037 WebCore::PerformanceResourceTiming::PerformanceResourceTiming(WebCore::ResourceTimingInfo const&, WebCore::Document*, double, double, bool, bool) > [Resource Timing] Expose redirect timing information > > This change contains redirect timing information for W3C Resource Timing spec, and tests. > > Contributed by pan.deng@intel.com > > BUG=None > > Review URL: https://chromiumcodereview.appspot.com/13912021 TBR=pan.deng@intel.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -571 lines) Patch
D trunk/LayoutTests/http/tests/w3c/webperf/resources/multi_redirect.php View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect.html View 1 chunk +0 lines, -54 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect_chain.html View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect_chain-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect_chain_allow_timing.html View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect_chain_allow_timing-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect_with_timing_allow_origin.html View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_redirect_with_timing_allow_origin-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_same_origin_redirect.html View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_same_origin_redirect-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/loader/ResourceLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/loader/cache/CachedResourceLoader.h View 3 chunks +1 line, -4 lines 0 comments Download
M trunk/Source/core/loader/cache/CachedResourceLoader.cpp View 3 chunks +10 lines, -20 lines 0 comments Download
M trunk/Source/core/page/Performance.h View 3 chunks +1 line, -3 lines 0 comments Download
M trunk/Source/core/page/Performance.cpp View 2 chunks +2 lines, -70 lines 0 comments Download
M trunk/Source/core/page/PerformanceResourceTiming.h View 2 chunks +4 lines, -12 lines 0 comments Download
M trunk/Source/core/page/PerformanceResourceTiming.cpp View 9 chunks +47 lines, -28 lines 0 comments Download
D trunk/Source/core/page/ResourceTimingInfo.h View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
7 years, 6 months ago (2013-06-09 12:01:25 UTC) #1
tkent
Committed patchset #1 manually as r152083.
7 years, 6 months ago (2013-06-09 12:01:45 UTC) #2
tkent
It broke many layout tests too. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/9336/steps/webkit_tests/logs/stdio Regressions: Unexpected crashes (29) http/tests/appcache/cyrillic-uri.html [ Crash ] ...
7 years, 6 months ago (2013-06-09 12:11:59 UTC) #3
Pan
7 years, 6 months ago (2013-06-13 01:26:04 UTC) #4
Sorry for late reply, I was on a holiday, I will check it today :)

Thanks!
Pan

-----Original Message-----
From: tkent@chromium.org [mailto:tkent@chromium.org] 
Sent: Sunday, June 09, 2013 8:12 PM
To: Deng, Pan
Cc: blink-reviews@chromium.org
Subject: Re: Revert 152077 "[Resource Timing] Expose redirect timing
information" (issue 16603005)


It broke many layout tests too.
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%...

Regressions: Unexpected crashes (29)
   http/tests/appcache/cyrillic-uri.html [ Crash ]
   http/tests/appcache/fallback.html [ Crash ]
   http/tests/appcache/foreign-fallback.html [ Crash ]
   http/tests/appcache/main-resource-hash.html [ Crash ]
   http/tests/appcache/main-resource-redirect.html [ Crash ]
   http/tests/appcache/non-html.xhtml [ Crash ]
   http/tests/appcache/offline-access.html [ Crash ]
   http/tests/appcache/remove-cache.html [ Crash ]
   http/tests/appcache/top-frame-2.html [ Crash ]
   http/tests/appcache/top-frame-3.html [ Crash ]
   http/tests/appcache/top-frame-4.html [ Crash ]
   http/tests/appcache/video.html [ Crash ]
   http/tests/appcache/xhr-foreign-resource.html [ Crash ]
   http/tests/inspector/appcache/appcache-iframe-manifests.html [ Crash ]
   http/tests/inspector/appcache/appcache-swap.html [ Crash ]
   http/tests/security/mixedContent/insecure-xhr-in-main-frame.html [ Crash ]
   http/tests/security/video-cross-origin-readback.html [ Crash ]
   http/tests/xmlhttprequest/access-control-and-redirects-async.html [ Crash ]

http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html
[ Crash ]

http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html
[ Crash ]

http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
[ Crash ]
   http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html
[
Crash ]
    
http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html [
Crash ]
   http/tests/xmlhttprequest/access-control-preflight-credential-async.html [
Crash ]
   http/tests/xmlhttprequest/access-control-preflight-headers-async.html [ Crash
]

http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html
[ Crash ]
   http/tests/xmlhttprequest/access-control-response-with-body.html [ Crash ]
   http/tests/xmlhttprequest/cross-origin-preflight-get.html [ Crash ]

http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html
[ Crash ]



https://codereview.chromium.org/16603005/

Powered by Google App Engine
This is Rietveld 408576698