Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/ui/view_ids.h

Issue 1660273003: Keep focus on Find-In-Page buttons when using the keyboard to navigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove viewIDs for findbar and add them to the exception list. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This defines an enumeration of IDs that can uniquely identify a view within 5 // This defines an enumeration of IDs that can uniquely identify a view within
6 // the scope of a container view. 6 // the scope of a container view.
7 7
8 #ifndef CHROME_BROWSER_UI_VIEW_IDS_H_ 8 #ifndef CHROME_BROWSER_UI_VIEW_IDS_H_
9 #define CHROME_BROWSER_UI_VIEW_IDS_H_ 9 #define CHROME_BROWSER_UI_VIEW_IDS_H_
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // The Bookmark Bar. 63 // The Bookmark Bar.
64 VIEW_ID_BOOKMARK_BAR, 64 VIEW_ID_BOOKMARK_BAR,
65 VIEW_ID_OTHER_BOOKMARKS, 65 VIEW_ID_OTHER_BOOKMARKS,
66 VIEW_ID_MANAGED_BOOKMARKS, 66 VIEW_ID_MANAGED_BOOKMARKS,
67 VIEW_ID_SUPERVISED_BOOKMARKS, 67 VIEW_ID_SUPERVISED_BOOKMARKS,
68 // Used for bookmarks/folders on the bookmark bar. 68 // Used for bookmarks/folders on the bookmark bar.
69 VIEW_ID_BOOKMARK_BAR_ELEMENT, 69 VIEW_ID_BOOKMARK_BAR_ELEMENT,
70 70
71 // Find in page. 71 // Find in page.
72 VIEW_ID_FIND_IN_PAGE_TEXT_FIELD, 72 VIEW_ID_FIND_IN_PAGE_TEXT_FIELD,
73 VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON,
74 VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON,
75 VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON,
73 76
74 // Tab Container window. 77 // Tab Container window.
75 VIEW_ID_TAB_CONTAINER, 78 VIEW_ID_TAB_CONTAINER,
76 79
77 // Docked dev tools. 80 // Docked dev tools.
78 VIEW_ID_DEV_TOOLS_DOCKED, 81 VIEW_ID_DEV_TOOLS_DOCKED,
79 82
80 // The contents split. 83 // The contents split.
81 VIEW_ID_CONTENTS_SPLIT, 84 VIEW_ID_CONTENTS_SPLIT,
82 85
83 // The Infobar container. 86 // The Infobar container.
84 VIEW_ID_INFO_BAR_CONTAINER, 87 VIEW_ID_INFO_BAR_CONTAINER,
85 88
86 // The Download shelf. 89 // The Download shelf.
87 VIEW_ID_DOWNLOAD_SHELF, 90 VIEW_ID_DOWNLOAD_SHELF,
88 91
89 // Used in chrome/browser/ui/cocoa/view_id_util_browsertest.mm. 92 // Used in chrome/browser/ui/cocoa/view_id_util_browsertest.mm.
90 // If you add new ids, make sure the above test passes. 93 // If you add new ids, make sure the above test passes.
91 VIEW_ID_PREDEFINED_COUNT, 94 VIEW_ID_PREDEFINED_COUNT,
92 95
93 // Plus button on location bar. 96 // Plus button on location bar.
94 VIEW_ID_ACTION_BOX_BUTTON, 97 VIEW_ID_ACTION_BOX_BUTTON,
95 }; 98 };
96 99
97 #endif // CHROME_BROWSER_UI_VIEW_IDS_H_ 100 #endif // CHROME_BROWSER_UI_VIEW_IDS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/view_id_util_browsertest.mm ('k') | chrome/browser/ui/views/find_bar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698